Add privacy policy content registration#869
Open
masteradhoc wants to merge 2 commits intoWordPress:masterfrom
Open
Add privacy policy content registration#869masteradhoc wants to merge 2 commits intoWordPress:masterfrom
masteradhoc wants to merge 2 commits intoWordPress:masterfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jeffpaul
reviewed
Apr 16, 2026
Member
jeffpaul
left a comment
There was a problem hiding this comment.
Functional approach and rationale sounds fine to me, will defer to others on technical review of implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes #868
Adds suggested privacy policy content for the Two Factor plugin via the WordPress Privacy Policy Guide (
wp_add_privacy_policy_content).Why?
WordPress provides a built-in mechanism for plugins to contribute suggested text to a site's privacy policy page. The Two Factor plugin stores personal data (TOTP secret keys, backup codes, enabled provider settings) but has never registered suggested privacy policy text, leaving site administrators without guidance on what to disclose.
How?
admin_initaction that calls a new static methodTwo_Factor_Core::add_privacy_policy_content().wp_add_privacy_policy_content()with a suggested block of text covering:Testing Instructions
Screenshots or screencast
Changelog Entry
Added - Register suggested privacy policy content via
wp_add_privacy_policy_contentso site administrators are guided on disclosing Two Factor authentication data.