Tighten prose-PR envelope + add sweep_report*.json to .gitignore#42
Open
JimCollinson wants to merge 2 commits into
Open
Tighten prose-PR envelope + add sweep_report*.json to .gitignore#42JimCollinson wants to merge 2 commits into
JimCollinson wants to merge 2 commits into
Conversation
PR #41 hit prose-guard because the routine bundled a useful .gitignore addition (ignore transient sweep_report*.json files) into a prose PR. PR #37 hit the same shape of issue with a misnamed sweep summary file. Both cases were the routine doing legitimate infrastructure tidying during the audit and silently bundling it into the prose envelope, where prose-guard correctly rejects it. Add an explicit "stay strictly within the prose envelope" bullet to step 5.2's Prose PR section that names the categories of root-level housekeeping the routine has slipped on (.gitignore, scripts/, .github/, repo-registry.yml, component-registry.yml) and points to "Suggested follow-ups" in the PR body as the place to surface infrastructure cleanups the audit noticed. A human can then open a separate PR for those. No rule duplication; this just makes the existing prose-guard envelope explicit at the moment the routine is assembling the PR. https://claude.ai/code/session_019cz1M7pXuXFQykMZxfdXHm
scripts/sweep_poll.py writes sweep_report.json on every routine run and on local validation invocations. The file is never part of the docs assembly, and committing it would just create noise in PR diffs. This addition was first attempted as part of prose PR #41 (commit 73114b6), which the prose-guard correctly rejected because the prose envelope does not cover root-level housekeeping. Landing it as a standalone change here. https://claude.ai/code/session_019cz1M7pXuXFQykMZxfdXHm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small follow-ups to PR #41's prose-guard failure:
Tighten the routine prompt so prose PRs stay strictly within the prose envelope. The routine has now twice (PR docs: antd v0.6.1 — health fields, upload visibility, MCP port discovery #37, PR prose: update CLI and Rust library reference for ant-client timeout split — 2026-05-13 #41) done legitimate infrastructure tidying during the audit and silently bundled it into the prose PR, where prose-guard correctly rejects it. The new bullet in step 5.2 names the specific categories the routine has slipped on (
.gitignore,scripts/,.github/,repo-registry.yml,component-registry.yml) and tells the routine to surface infrastructure cleanups in a "Suggested follow-ups" section of the PR body instead. Humans can then open separate PRs.Add
sweep_report*.jsonto.gitignore. The routine writessweep_report.jsonon every run, and local invocations ofscripts/sweep_poll.pydo the same. Never part of the docs assembly. This addition was first attempted inside PR prose: update CLI and Rust library reference for ant-client timeout split — 2026-05-13 #41 (commit73114b6) and correctly rejected — landing it as the kind of standalone change the new prompt bullet is designed to encourage.Test plan
git statusshowssweep_report.jsonis now ignored after the routine writes one.https://claude.ai/code/session_019cz1M7pXuXFQykMZxfdXHm
Generated by Claude Code