feat(antd-php): expose new HealthStatus diagnostic fields#48
Merged
Conversation
Mirrors antd-go v0.5.0 / antd-py: HealthStatus now carries \$version,
\$evmNetwork, \$uptimeSeconds, \$buildCommit, \$paymentTokenAddress,
and \$paymentVaultAddress as readonly promoted properties. All have
default values ('' / 0) so existing two-arg HealthStatus(ok, network)
calls keep compiling and pre-0.4.0 daemon responses parse cleanly.
Sync health() and async healthAsync() share a private static
healthStatusFromJson() helper to keep the field-mapping in one place.
antd-php is REST-only (no gRPC client). No proto regen step needed.
AntdClientTest mock fixture extended to populate all 6 fields.
testHealth asserts each. New testHealthPreV0_4_0Daemon exercises the
empty-defaults path.
Note: composer isn't available on the orchestrator's Windows host;
phpunit was not run locally. php -l confirmed no syntax errors in the
edited files.
Part of #37.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirrors the daemon-side enrichment shipped in #38:
HealthStatusnow carriesversion,evm_network/evmNetwork,uptime_seconds/uptimeSeconds,build_commit/buildCommit,payment_token_address/paymentTokenAddress,payment_vault_address/paymentVaultAddress. All default to""/0so the type stays constructable when talking to a pre-0.4.0 daemon.Test plan
Part of #37.
🤖 Generated with Claude Code