feat(antd-ruby): expose new HealthStatus diagnostic fields#47
Merged
Conversation
Mirrors antd-go v0.5.0 / antd-py: HealthStatus now carries :version, :evm_network, :uptime_seconds, :build_commit, :payment_token_address, and :payment_vault_address. The keyword-init Struct.new gains an explicit initialize that defaults the diagnostic kwargs to "" / 0 so existing two-arg HealthStatus.new(ok:, network:) calls keep working and pre-0.4.0 daemon responses parse cleanly. REST `Client#health` and gRPC `GrpcClient#health` populate the new fields via Hash#fetch(... "") (REST) and direct getters on the regenerated HealthCheckResponse proto (gRPC). Proto stubs are regenerated locally via grpc_tools_ruby_protoc — they remain untracked, consistent with the pre-existing setup. Mock fixture in test_client.rb extended to populate all 6 fields. Existing test_health asserts each. New test_health_pre_0_4_0_daemon exercises the empty-defaults path. Note: bundle install on the orchestrator's Windows host requires MSYS2 which isn't installed; tests were not run locally. Part of #37. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirrors the daemon-side enrichment shipped in #38:
HealthStatusnow carriesversion,evm_network/evmNetwork,uptime_seconds/uptimeSeconds,build_commit/buildCommit,payment_token_address/paymentTokenAddress,payment_vault_address/paymentVaultAddress. All default to""/0so the type stays constructable when talking to a pre-0.4.0 daemon.Test plan
Part of #37.
🤖 Generated with Claude Code