feat(chunk-get): emit per-failure close-group summary at info level#86
Merged
jacderida merged 1 commit intoMay 12, 2026
Merged
Conversation
When chunk_get exhausts its close group without finding the chunk, emit a single info-level summary line covering the count of peers queried and the per-peer terminal outcome (NotFound / Timeout / Network error). Motivation: when a client reports "Chunk not found", the existing per-peer debug lines don't tell operators (or downstream tooling) whether the cause was genuine data loss (every close-group peer responded NotFound) or a reachability problem from the client's vantage (peers timed out before responding). The summary line surfaces that distinction in a single greppable line at -v (info) verbosity, so it doesn't require -vv debug logs to recover after the fact. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When `chunk_get` exhausts its close group without finding the chunk, emit a single info-level summary line covering the count of peers queried and the per-peer terminal outcome (NotFound / Timeout / Network error).
Example output (under `-v`):
```
chunk_get exhausted close group for a5faabc4dcd18f18…: queried=7 not_found=7 timeout=0 network_err=0
```
Motivation
When a client reports `Chunk not found`, the existing per-peer `debug!` lines don't tell operators (or downstream tooling) whether the cause was genuine data loss (every close-group peer responded NotFound) or a reachability problem from the client's vantage (peers timed out before responding). The summary line surfaces that distinction in a single greppable line at `-v` (info) verbosity, so it doesn't require `-vv` debug logs to recover after the fact.
The signal directly supports the canary monitoring we're standing up to measure chunk-loss rates on the production network: each probe parses this line into a structured `terminal_peer_outcomes` record, letting us classify each failed probe as data-loss vs reachability without needing `-vv` log volumes or cross-vantage triangulation.
Test plan
🤖 Generated with Claude Code