Extract yzmap to shared IYZMap service, reducing 720 local maps to 2 …#466
Draft
HaiwangYu wants to merge 1 commit intoWireCell:masterfrom
Draft
Extract yzmap to shared IYZMap service, reducing 720 local maps to 2 …#466HaiwangYu wants to merge 1 commit intoWireCell:masterfrom
HaiwangYu wants to merge 1 commit intoWireCell:masterfrom
Conversation
…instances Introduce IYZMap interface and YZMap implementation that loads the full 4-level JSON map (anode, plane, binz, biny) once. DepoSetFilterYZ and Scaler now hold an IYZMap::pointer and delegate all binning/clamping to the service via value(anode_name, plane, y, z). ICARUS Jsonnet configs define one shared YZMap per JSON file instead of per-instance parameters. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…instances
Introduce IYZMap interface and YZMap implementation that loads the full 4-level JSON map (anode, plane, binz, biny) once. DepoSetFilterYZ and Scaler now hold an IYZMap::pointer and delegate all binning/clamping to the service via value(anode_name, plane, y, z). ICARUS Jsonnet configs define one shared YZMap per JSON file instead of per-instance parameters.