chore(config): migrate config .github/renovate.json#951
chore(config): migrate config .github/renovate.json#951Wikid82 merged 2 commits intofeature/beta-releasefrom
Conversation
chore(config): migrate Renovate config
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Migrates the Renovate configuration to updated keys/pattern-based settings under .github/renovate.json.
Changes:
- Switched Renovate base branch targeting from
baseBranchestobaseBranchPatterns. - Updated GitHub Actions manager configuration to use
managerFilePatterns. - Adjusted the “MEGAZORD” package rule matching from
matchPackagePatternstomatchPackageNames.
| "managerFilePatterns": [ | ||
| "/^\\.github/skills/examples/.*\\.ya?ml$/" | ||
| ] |
There was a problem hiding this comment.
"managerFilePatterns"with a string like"/^...$/"is likely not interpreted as intended by Renovate. For manager configs, Renovate typically expectsfileMatchwith regex *strings* (no leading/trailing/delimiters), e.g."^\.github/skills/examples/.*\.ya?ml$"`. As written, this may prevent the github-actions manager from matching any files.
| "matchPackageNames": [ | ||
| "*" |
There was a problem hiding this comment.
Replacing "matchPackagePatterns": ["*"] with "matchPackageNames": ["*"] changes semantics and likely won’t match all packages. matchPackageNames generally matches explicit names (or regex-style values), so "*" may only match a literal package named "*". To match everything, keep matchPackagePatterns (e.g. ".*") or use a regex-style entry for names (depending on the Renovate schema supported here).
| "matchPackageNames": [ | |
| "*" | |
| "matchPackagePatterns": [ | |
| ".*" |
| "helpers:pinGitHubActionDigests" | ||
| ], | ||
| "baseBranches": [ | ||
| "baseBranchPatterns": [ |
There was a problem hiding this comment.
Using baseBranchPatterns with unanchored values like "development" can unintentionally match branches that merely contain that substring (depending on Renovate’s pattern interpretation). If the intent is to target only the exact branches, prefer anchoring the patterns (e.g. ^development$) or keep baseBranches for exact branch names.
| "baseBranchPatterns": [ | |
| "baseBranches": [ |
No description provided.