chore(config): migrate config .github/renovate.json#950
Conversation
chore(config): migrate Renovate config
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Migrates Renovate configuration keys/patterns in .github/renovate.json, apparently to align with newer Renovate config conventions.
Changes:
- Replaces
baseBrancheswithbaseBranchPatterns. - Updates the GitHub Actions manager config from
fileMatchtomanagerFilePatterns. - Changes a package rule matcher from
matchPackagePatternstomatchPackageNames.
| "helpers:pinGitHubActionDigests" | ||
| ], | ||
| "baseBranches": [ | ||
| "baseBranchPatterns": [ |
There was a problem hiding this comment.
baseBranchesis a well-known Renovate option, butbaseBranchPatternsis not (it may be ignored depending on Renovate version). If Renovate ignores this key, updates will run against the default base branch set rather than the intended branches. Prefer usingbaseBranches, or confirm (with docs/version in use) that baseBranchPatterns` is supported in your Renovate runtime.
| "baseBranchPatterns": [ | |
| "baseBranches": [ |
| "managerFilePatterns": [ | ||
| "/^\\.github/skills/examples/.*\\.ya?ml$/" |
There was a problem hiding this comment.
This looks like it’s switching from Renovate’s typical fileMatch regex-list format to an option name/value format that Renovate may not recognize for the github-actions manager. Additionally, the regex is wrapped in /.../, while Renovate commonly expects plain regex strings (e.g., ^\\.github/...$) rather than slash-delimited literals. As written, Renovate may fail to match any files (or ignore the config block). Consider reverting to fileMatch and using unslashed regex strings if you intend regex matching.
| "managerFilePatterns": [ | |
| "/^\\.github/skills/examples/.*\\.ya?ml$/" | |
| "fileMatch": [ | |
| "^\\.github/skills/examples/.*\\.ya?ml$" |
| ], | ||
| "groupName": "non-major-updates" | ||
| "groupName": "non-major-updates", | ||
| "matchPackageNames": [ |
There was a problem hiding this comment.
Replacing matchPackagePatterns: ["*"] with matchPackageNames: ["*"] likely changes semantics: matchPackageNames typically matches exact package names (or explicit names), so "*" may not function as a wildcard and may result in this rule matching nothing. If the goal is “all packages”, keep matchPackagePatterns: ["*"] (or use the documented “match all” approach for your Renovate version).
| "matchPackageNames": [ | |
| "matchPackagePatterns": [ |
✅ Supply Chain Verification Results✅ PASSED 📦 SBOM Summary
🔍 Vulnerability Scan
📎 Artifacts
Generated by Supply Chain Verification workflow • View Details |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
No description provided.