Open
Conversation
dianafa
reviewed
May 9, 2017
|
|
||
| Keep entry point files as small as possible. They should usually just execute some initialization functions from other files. | ||
| ``` | ||
| TODO: what if we want to have just one js file in extension? |
Contributor
There was a problem hiding this comment.
what would be the case when we 'want' such solution?
Author
There was a problem hiding this comment.
I think there is no need to create multiple files if we want to for example add just one button click handler.
dianafa
reviewed
May 9, 2017
|
|
||
| return Tracking; | ||
| }); | ||
| ``` |
Contributor
There was a problem hiding this comment.
in case we have static methods only do we want to have convention regarding
Tracking.myStaticFunction1 = function () {
// public non-static method
};
Tracking.myStaticFunction2 = function () {
// public static method
};
return Tracking;
over
myStaticFunction1 = function () {
// public non-static method
};
myStaticFunction2 = function () {
// public static method
};
return {
myStaticFunction1: myStaticFunction1,
myStaticFunction2: myStaticFunction2
};
as well?
Contributor
|
@latata is this still relevant or should we close this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposal draft for conventions of Wikia App JavaScript modules structure. Feel free to expand it or leave your comments.
@kvas-damian @rogatty @fraszczakszymon @dianafa @slayful