Merged
Conversation
Reviewer's GuideDocuments the Desktop v1 runtime/release boundary across desktop docs, ADRs, and README, clarifying that legacy remains the default runtime, React is a validated selectable runtime and future direction, and that certain cleanup/feature issues are post-v1 or require re-scoping. State diagram for Desktop v1 release boundary and post-v1 workstateDiagram-v2
[*] --> Desktop_v0_1
state Desktop_v0_1 {
[*] --> Legacy_default
Legacy_default: Legacy runtime is v0_1 release surface
}
Desktop_v0_1 --> Desktop_v1: Define_v1_boundary_issue_442
state Desktop_v1 {
direction LR
Legacy_default_v1: Legacy remains default release runtime
React_selectable_v1: React is validated selectable runtime
Transitional_APIs_v1: research_ui is transitional API and reachability boundary
Legacy_default_v1 --> React_selectable_v1
React_selectable_v1 --> Transitional_APIs_v1
}
Desktop_v1 --> Post_v1_cleanup: Remaining_migration_work
state Post_v1_cleanup {
direction TB
React_default_runtime: Make React the default runtime
Legacy_renderer_removal: Remove legacy shell renderer
Launch_boundary_resolution: Resolve remaining Launch_operator_flow boundary
React_default_runtime --> Legacy_renderer_removal
Launch_boundary_resolution --> React_default_runtime
}
Desktop_v1 --> Blocked_re_scoped_issues: Issues_with_preconditions
state Blocked_re_scoped_issues {
direction TB
Issue_412: Broad_legacy_deletion_blocked_until_preconditions
Issue_266: Post_v1_or_recut_into_smaller_release_alignment_slice
}
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The v1 runtime definition text is repeated with very similar wording across multiple docs; consider centralizing the canonical wording in one place and referencing it elsewhere to reduce future drift.
- There are small inconsistencies in issue formatting (e.g.,
#442vs #442) across files; standardizing how issues are referenced would make the guidance easier to scan and maintain. - In places where you describe what is 'not required' for v1 (e.g., legacy removal, React default), it may help to explicitly call out what does constitute the minimal v1 acceptance criteria to avoid interpretive gaps for future slices.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The v1 runtime definition text is repeated with very similar wording across multiple docs; consider centralizing the canonical wording in one place and referencing it elsewhere to reduce future drift.
- There are small inconsistencies in issue formatting (e.g., `#442` vs #442) across files; standardizing how issues are referenced would make the guidance easier to scan and maintain.
- In places where you describe what is 'not required' for v1 (e.g., legacy removal, React default), it may help to explicitly call out what *does* constitute the minimal v1 acceptance criteria to avoid interpretive gaps for future slices.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #442.
Summary
Out of scope
Validation
git diff --checkSummary by Sourcery
Document the Desktop v1 runtime and release boundary, clarifying the relationship between the legacy and React runtimes and how they factor into the v1 operator workstation release state.
Documentation:
research_uiremains a transitional API boundary rather than a product surface owner.