Skip to content

desktop(test): make fallback smoke validate React runtime#434

Merged
Whiteks1 merged 1 commit intomainfrom
codex/issue-431-react-smoke-plan
Apr 20, 2026
Merged

desktop(test): make fallback smoke validate React runtime#434
Whiteks1 merged 1 commit intomainfrom
codex/issue-431-react-smoke-plan

Conversation

@Whiteks1
Copy link
Copy Markdown
Owner

Summary

Closes #431.

This PR keeps the existing legacy fallback smoke path intact and adds an explicit React fallback smoke path for the selectable React runtime introduced in #430.

What changed

  • Added npm run smoke:react:fallback.
  • Extended scripts/smoke.js with --renderer=legacy|react while preserving legacy as the default.
  • Added a stable React renderer signal through window.__quantlab and a DOM marker for smoke readiness.
  • Made smoke workbench checks distinguish legacy shell readiness from React shell readiness.
  • Updated the happy-path smoke flow so React can re-open Runs and navigate to Compare after selecting runs.
  • Allowed smoke fixtures under QUANTLAB_DESKTOP_OUTPUTS_ROOT to be read by the React runtime without weakening local path boundaries.
  • Restored listDirectory to the bridge contract shape { entries, truncated }.

Scope boundary

This does not make React the default renderer, does not touch #432 or #412, does not remove research_ui, does not redesign smoke broadly, and does not change layout/brand/Launch behavior beyond smoke observation.

Validation

  • npm run -s typecheck
  • npm run -s build
  • npm run -s smoke:fallback
  • npm run -s smoke:react:fallback
  • node --test tests/snapshot-status.test.mjs
  • git diff --check

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @Whiteks1, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@Whiteks1 Whiteks1 marked this pull request as ready for review April 20, 2026 21:20
@Whiteks1 Whiteks1 merged commit f426ba6 into main Apr 20, 2026
3 checks passed
@Whiteks1 Whiteks1 deleted the codex/issue-431-react-smoke-plan branch April 20, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

desktop(test): make smoke validation React-runtime ready

1 participant