desktop(react): make React runtime own migrated workstation surfaces#433
Merged
desktop(react): make React runtime own migrated workstation surfaces#433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #430.
This PR makes the selectable React renderer mount the migrated QuantLab workstation shell instead of the previous placeholder runtime. It keeps the legacy renderer as the default and does not touch smoke, research_ui cutoff, or legacy cleanup.
What changed
desktop/renderer/src/App.tsx.QuantLabContext.jsxinto a React-owned provider backed by the preload bridge (window.quantlabDesktop) instead ofapp-legacy.jsglobals.Scope boundary
#430 formalizes React runtime ownership of the migrated workstation surfaces. It does not make React the default renderer, change smoke validation, expand Launch, remove
research_ui, or retire the legacy shell.Validation
npm cinpm run -s typechecknpm run -s buildnode --test tests/snapshot-status.test.mjsgit diff --checkQUANTLAB_DESKTOP_RENDERER=reactstayed up for 12 seconds without early exit