Skip to content

desktop(react): make React runtime own migrated workstation surfaces#433

Merged
Whiteks1 merged 1 commit intomainfrom
codex/issue-430-react-runtime-ownership
Apr 20, 2026
Merged

desktop(react): make React runtime own migrated workstation surfaces#433
Whiteks1 merged 1 commit intomainfrom
codex/issue-430-react-runtime-ownership

Conversation

@Whiteks1
Copy link
Copy Markdown
Owner

Summary

Closes #430.

This PR makes the selectable React renderer mount the migrated QuantLab workstation shell instead of the previous placeholder runtime. It keeps the legacy renderer as the default and does not touch smoke, research_ui cutoff, or legacy cleanup.

What changed

  • Replaced the React placeholder entry with the migrated workstation shell through desktop/renderer/src/App.tsx.
  • Reworked QuantLabContext.jsx into a React-owned provider backed by the preload bridge (window.quantlabDesktop) instead of app-legacy.js globals.
  • Added React-owned tab routing for migrated surfaces: Runs, Run Detail, Compare, Candidates, System, Experiments, and Paper Ops.
  • Kept Launch and Assistant visible as explicit paused React runtime boundaries without expanding product scope.
  • Updated System, Experiments, and Paper Ops adapters so they read from the React-owned context rather than simulated legacy state.

Scope boundary

#430 formalizes React runtime ownership of the migrated workstation surfaces. It does not make React the default renderer, change smoke validation, expand Launch, remove research_ui, or retire the legacy shell.

Validation

  • npm ci
  • npm run -s typecheck
  • npm run -s build
  • node --test tests/snapshot-status.test.mjs
  • git diff --check
  • Bounded React launch check: Electron with QUANTLAB_DESKTOP_RENDERER=react stayed up for 12 seconds without early exit

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @Whiteks1, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@Whiteks1 Whiteks1 marked this pull request as ready for review April 20, 2026 20:41
@Whiteks1 Whiteks1 merged commit 18a5d63 into main Apr 20, 2026
3 checks passed
@Whiteks1 Whiteks1 deleted the codex/issue-430-react-runtime-ownership branch April 20, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

desktop(react): make React shell own migrated workstation surfaces

1 participant