fix(desktop): restore legacy run detail render path#428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #427.
Summary
kind: "run"render path inrenderTabs().renderRunTabrenderer so.run-detail-shellis emitted again.openRunDetailTab(runId, { subview: "artifacts" }); this PR does not restore a separateartifacts:tab surface.Scope
openTabfixes,useLegacyBridgecleanup, React renderer debt, desktop(product): formalize launch target-state and research_ui retirement plan #411/desktop(cleanup): post-v1 legacy shell retirement boundary #412, shell bootstrap rewrites, separate artifacts tab restoration.Validation
npm cipassed; it still reports existing dev audit findings (2 moderate, 1 high), not addressed in this slice.npm run -s typecheckpassed.npm run -s buildpassed.npm run -s smoke:fallbackpassed.node --test tests/snapshot-status.test.mjspassed.git diff --checkpassed.Local real-path note
npm run -s smoke:real-pathnow reaches the fixed target state for fix(desktop): resolve shell bootstrap hasShell=false smoke regression #427:happyPathRunDetailReady=trueandhappyPathArtifactsReady=true.research_uiis not registered as reachable by the smoke service (serverReady=false,apiReady=false,serverUrl=""). That is a separate server reachability/registration condition from thehasShell=falseregression fixed here.