Skip to content

fix(desktop): restore legacy run detail render path#428

Merged
Whiteks1 merged 1 commit intomainfrom
codex/issue-427-restore-run-render
Apr 20, 2026
Merged

fix(desktop): restore legacy run detail render path#428
Whiteks1 merged 1 commit intomainfrom
codex/issue-427-restore-run-render

Conversation

@Whiteks1
Copy link
Copy Markdown
Owner

Closes #427.

Summary

  • Restores the legacy kind: "run" render path in renderTabs().
  • Reconnects the existing renderRunTab renderer so .run-detail-shell is emitted again.
  • Keeps the desktop(migration): run detail and artifact explorer native surfaces #409 artifacts decision intact: artifacts remain integrated into Run Detail via openRunDetailTab(runId, { subview: "artifacts" }); this PR does not restore a separate artifacts: tab surface.

Scope

Validation

  • npm ci passed; it still reports existing dev audit findings (2 moderate, 1 high), not addressed in this slice.
  • npm run -s typecheck passed.
  • npm run -s build passed.
  • npm run -s smoke:fallback passed.
  • node --test tests/snapshot-status.test.mjs passed.
  • git diff --check passed.

Local real-path note

  • npm run -s smoke:real-path now reaches the fixed target state for fix(desktop): resolve shell bootstrap hasShell=false smoke regression #427: happyPathRunDetailReady=true and happyPathArtifactsReady=true.
  • Local Windows real-path still exits non-zero because research_ui is not registered as reachable by the smoke service (serverReady=false, apiReady=false, serverUrl=""). That is a separate server reachability/registration condition from the hasShell=false regression fixed here.

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @Whiteks1, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@Whiteks1 Whiteks1 merged commit 663752c into main Apr 20, 2026
3 checks passed
@Whiteks1 Whiteks1 deleted the codex/issue-427-restore-run-render branch April 20, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(desktop): resolve shell bootstrap hasShell=false smoke regression

1 participant