Open
Conversation
arcuri82
requested changes
Mar 8, 2026
| @Cfg("If using THRESHOLD for AI Classification Repair, specify its value." + | ||
| " All classifications with probability equal or above such threshold value will be accepted.") | ||
| var classificationRepairThreshold = 0.8 | ||
| var classificationRepairThreshold = 0.5 |
Collaborator
There was a problem hiding this comment.
are these changes based on latest experiments?
Collaborator
There was a problem hiding this comment.
ah... i see you wrote it in the description of this PR... :)
| @Cfg("Minimum confidence threshold required for the AI response classifier to decide" + | ||
| "whether to send a request as-is or attempt a repair.") | ||
| var aIResponseClassifierWeaknessThreshold = 0.4 | ||
| var aIResponseClassifierWeaknessThreshold = 0.8 |
Collaborator
There was a problem hiding this comment.
are these changes based on latest experiments?
|
|
||
| for(ok in ok2xx){ | ||
|
|
||
| if (isWeakClassifier(model, ok, weaknessThreshold)) continue |
Collaborator
There was a problem hiding this comment.
i m unsure about this... we will need to discuss. for example, if the model is always weak, would it mean this test will always pass? that would be against the point of having a E2E. or is guassian not able to reliably solve these simples APIs in these E2Es?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update thresholds and AIClassificationEMTestBase based on the last set of experiments.