fix: show install buttons on macOS after update download completes#207
Open
pedromdbl wants to merge 1 commit into
Open
fix: show install buttons on macOS after update download completes#207pedromdbl wants to merge 1 commit into
pedromdbl wants to merge 1 commit into
Conversation
Remove !window.api.platform.isMacOS condition that hid the "Install Now" / "Later" buttons on macOS after download. If quitAndInstall fails silently, users were left stuck with no buttons and no way to retry. Closes Venipa#206
dosubot
Bot
added
size:L
Owner
|
I'll test the upgrade process to confirm once im done with work |
Venipa
force-pushed
the
master
branch
4 times, most recently
from
62101c8 to
bda50be
Compare
Contributor
Author
|
@Venipa the bug happened again while trying to install the latest version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
!window.api.platform.isMacOScondition that hid the "Install Now" / "Later" buttons on macOS after downloadautoUpdater.quitAndInstall()fails silently, users were left stuck with no buttons and no way to retry or dismissTest plan
Closes #206