Skip to content

Fix symfony property info phpstan extractor compatibility version #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
root-aza merged 5 commits into from
May 26, 2026
Merged

Fix symfony property info phpstan extractor compatibility version #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
08850f4
Bumped pollyfill for symfony/property-info to 7.1.8
GroxExMachine May 22, 2026
62778db
Fixed compatibility with PhpStan 2.0
GroxExMachine May 22, 2026
ddc0958
Fixed compatibility with PhpStan 2.0
GroxExMachine May 22, 2026
38fbcb3
Fixed compatibility with PhpStan 2.0
GroxExMachine May 25, 2026
ce6595c
Fixed compatibility with PhpStan 2.0
GroxExMachine May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/Infrastructure/PropertyInfo/Extractor/PollyfillPhpStanExtractor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
use PHPStan\PhpDocParser\Parser\PhpDocParser;
use PHPStan\PhpDocParser\Parser\TokenIterator;
use PHPStan\PhpDocParser\Parser\TypeParser;
use PHPStan\PhpDocParser\ParserConfig;
use Symfony\Component\PropertyInfo\Extractor\ConstructorArgumentTypeExtractorInterface;
use Symfony\Component\PropertyInfo\Extractor\ReflectionExtractor;
use Symfony\Component\PropertyInfo\PropertyTypeExtractorInterface;
Expand Down Expand Up @@ -77,8 +78,18 @@ public function __construct(?array $mutatorPrefixes = null, ?array $accessorPref
$this->accessorPrefixes = $accessorPrefixes ?? ReflectionExtractor::$defaultAccessorPrefixes;
$this->arrayMutatorPrefixes = $arrayMutatorPrefixes ?? ReflectionExtractor::$defaultArrayMutatorPrefixes;

$this->phpDocParser = new PhpDocParser(new TypeParser(new ConstExprParser()), new ConstExprParser());
$this->lexer = new Lexer();
if (class_exists(ParserConfig::class)) { // PhpStan 2.0
$config = new ParserConfig([]);
$this->lexer = new Lexer($config);
$this->phpDocParser = new PhpDocParser(
$config,
new TypeParser($config, new ConstExprParser($config)),
new ConstExprParser($config)
);
} else {
$this->lexer = new Lexer();
$this->phpDocParser = new PhpDocParser(new TypeParser(new ConstExprParser()), new ConstExprParser());
}
$this->nameScopeFactory = new NameScopeFactory();
}

Expand Down
4 changes: 2 additions & 2 deletions src/RestClientBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,12 +98,12 @@ public static function create(PsrHttpClient $client, ?string $apiKey = null, ?st
$typeExtractors = [];

/* @infection-ignore-all */
if (isOldPackage('symfony/property-info', '6.1')) {
if (isOldPackage('symfony/property-info', '7.1.8')) {
$typeExtractors[] = new PollyfillPhpStanExtractor();
}

/* @infection-ignore-all */
if (!isOldPackage('symfony/property-info', '6.1')) {
if (!isOldPackage('symfony/property-info', '7.1.8')) {
$typeExtractors[] = new PhpStanExtractor();
}

Expand Down
Loading