Add tests for the default request timeout#2845
Merged
adamtheturtle merged 1 commit intomainfrom Feb 15, 2026
Merged
Conversation
Test that VWS and CloudRecoService requests succeed at 29 seconds and time out at 31 seconds, verifying the existing default timeout behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VWSandCloudRecoServiceTest plan
🤖 Generated with Claude Code
Note
Low Risk
Test-only changes that don’t modify runtime behavior; low risk aside from potential test flakiness around timing assumptions.
Overview
Adds new parametrized tests asserting the default ~30s HTTP request timeout behavior for both
CloudRecoService.queryandVWS.add_target.The tests use
MockVWSwith an artificial response delay andfreezegunto advance time, verifying a 29s delay succeeds while a 31s delay raisesrequests.exceptions.Timeout.Written by Cursor Bugbot for commit 2d64771. This will update automatically on new commits. Configure here.