Skip to content

Add VuMark to endpoint fixture for auth testing#2960

Merged
adamtheturtle merged 2 commits intomainfrom
adamtheturtle/vumark-auth-tests
Feb 18, 2026
Merged

Add VuMark to endpoint fixture for auth testing#2960
adamtheturtle merged 2 commits intomainfrom
adamtheturtle/vumark-auth-tests

Conversation

@adamtheturtle
Copy link
Member

@adamtheturtle adamtheturtle commented Feb 18, 2026

Summary

Adds VuMark instance generation endpoint to the parametrized endpoint fixture, enabling all existing auth tests to cover VuMark. Updates the Endpoint class to support endpoints that return binary data on success by making successful_headers_result_code optional. Updates test_date_header.py to properly handle VuMark's binary response format.

Changes

  • Adds vumark_generate_instance fixture in prepared_requests.py following the same pattern as other endpoints
  • Makes successful_headers_result_code: ResultCodes | None in Endpoint class to accommodate non-JSON responses
  • Adds VuMark to the parametrized endpoint fixture params in conftest.py
  • Updates test_date_header.py success assertions to handle None result codes

🤖 Generated with Claude Code


Note

Medium Risk
Touches core request validation/error-shaping and broadens multiple parametrized test suites, so mismatched endpoint detection or result-code handling could cause regressions across many service endpoints.

Overview
Adds the VuMark instance-generation endpoint (POST /targets/<id>/instances) to the shared parametrized endpoint fixture so existing auth/date/invalid-JSON tests run against VuMark as well.

Updates test utilities and assertions to handle VuMark’s binary success responses by allowing Endpoint.successful_headers_result_code to be None and skipping JSON result_code assertions in test_date_header. Separately, aligns mock service validation to return Vuforia’s BadRequest result_code for invalid JSON specifically on the /instances route by introducing ResultCodes.BAD_REQUEST, adding BadRequestError, and routing validate_json errors based on request_path.

Written by Cursor Bugbot for commit 04c35f6. This will update automatically on new commits. Configure here.

Adds a vumark_generate_instance fixture to the endpoint parametrization,
allowing all auth tests (missing header, malformed header, bad keys, etc.)
to also cover the VuMark instance generation endpoint. Updates the Endpoint
class to support endpoints with binary responses by making
successful_headers_result_code optional. Updates test_date_header.py to
handle VuMark's binary success response.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Real Vuforia returns result_code 'BadRequest' (not 'Fail') when invalid
JSON is sent to the VuMark instance generation endpoint. Adds the
BAD_REQUEST result code, a BadRequestError exception, and updates
validate_json() to raise the correct error based on the request path.
Updates the test to expect BadRequest for the /instances endpoint.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@adamtheturtle adamtheturtle merged commit f6644a9 into main Feb 18, 2026
106 checks passed
@adamtheturtle adamtheturtle deleted the adamtheturtle/vumark-auth-tests branch February 18, 2026 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments