-
Notifications
You must be signed in to change notification settings - Fork 2
Remove PyTorch dependencies #2959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adamtheturtle
wants to merge
2
commits into
main
Choose a base branch
from
adamtheturtle/smaller-torch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,6 +15,7 @@ beartype | |
| binascii | ||
| bool | ||
| boolean | ||
| brisque | ||
| bytesio | ||
| changelog | ||
| chunked | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| """Wrapper around the brisque package for image quality scoring.""" | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import io | ||
|
|
||
| import numpy as np | ||
| from brisque import ( # type: ignore[attr-defined] # pyright: ignore[reportMissingTypeStubs] | ||
| BRISQUE, | ||
| ) | ||
| from PIL import Image | ||
|
|
||
| _brisque_scorer = BRISQUE(url=False) # type: ignore[no-untyped-call] | ||
|
|
||
|
|
||
| def brisque_score(image_content: bytes) -> float: | ||
| """Return a BRISQUE quality score for the given image bytes.""" | ||
| image_file = io.BytesIO(initial_bytes=image_content) | ||
| image = Image.open(fp=image_file).convert(mode="RGB") | ||
| image_np: np.ndarray = np.array(object=image) | ||
| return float( | ||
| _brisque_scorer.score(img=image_np) # type: ignore[no-untyped-call] # pyright: ignore[reportUnknownMemberType] | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SSIM fails on grayscale images missing channel dimension
High Severity
The
structural_similaritycall unconditionally passeschannel_axis=2, but grayscale ("L" mode) images produce 2D numpy arrays with shape(H, W)— no axis 2 exists. The image validator explicitly allows grayscale images, so they can reach this code path. The old torch-based code handled this correctly viagetbands()and.view(). The_brisque.pywrapper avoids this by calling.convert(mode="RGB"), butimage_matchers.pydoes not convert images before creating numpy arrays.