-
Notifications
You must be signed in to change notification settings - Fork 2
Add comprehensive VuMark instance generation tests #2954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
adamtheturtle
merged 11 commits into
main
from
adamtheturtle/vumark-comprehensive-tests
Feb 18, 2026
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
76dd68e
Add comprehensive VuMark instance generation tests and mock support
adamtheturtle f65532d
Fix mypy errors in VuMark tests and Flask handler
adamtheturtle 5b19f90
Add svg and pdf to spelling private dictionary
adamtheturtle 179450f
Retry delete_target if TargetStatusProcessingError after update_target
adamtheturtle a0df2cb
Complete remaining todos: ResultCodes constants, spelling revert, retry
adamtheturtle 38f577e
Extract multipart parsing helper; revert retry changes to separate issue
adamtheturtle 9915a0e
Simplify valid_accept_types: content type equals accept key
adamtheturtle 0da9800
Merge main; keep comprehensive VuMark tests over basic test_generate_…
adamtheturtle 672a0ae
Remove duplicate _parse_multipart_files introduced by merge
adamtheturtle 9128b43
Fix Docker build on PRs; remove duplicate rst section
adamtheturtle f5a8243
Revert docker-build.yml change; Docker failure was transient
adamtheturtle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Case-insensitive header lookup lost by dict conversion
Low Severity
dict(request.headers).get("Accept", "")converts theCaseInsensitiveDictfromPreparedRequest.headersinto a plaindict, losing case-insensitive lookup. This means a header sent as e.g.accept: image/pngwon't be found, incorrectly triggeringInvalidAcceptHeaderError. The Flask backend at the equivalent point usesrequest.headers.get(key="Accept", default="")which preserves case-insensitive behavior, creating an inconsistency between the two mock backends.