support op_add in CollectConstVarsPass#1625
Open
apolyakov wants to merge 4 commits into
Open
Conversation
apolyakov
added
optimization
apolyakov
force-pushed
the
apolyakov/support-constant-op-add
branch
from
6b173c4 to
f35ed92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the
CollectConstVarsPasscompiler optimization to support the+operator (array union/addition) for constant expressions. This moves evaluation of constantarr + arrexpressions from request execution time to kPHP initialization stage.Implementation Details:
The optimization is currently limited to
arr + arrcase only. While the optimization would be safe for some other cases as well (the runtime handles type coercion),K2runtime's implementation of string addition requiresRuntimeContextto be initialized (which is not initialized at the time of constant initialization stage). To ensure compatibility with both legacy andK2runtimes, we restrict this optimization to array addition only.Example:
Before this change, an expression like
['a' => 1] + ['b' => 2]would be evaluated on every request. After this change, it's evaluated once during initialization and stored as a constant variable.