Remove --oldVersion and parse VersionPacket, support Artemis up to 2.8.x#3
Open
NoseyNick wants to merge 2 commits intoUserMcUser:masterfrom
Open
Remove --oldVersion and parse VersionPacket, support Artemis up to 2.8.x#3NoseyNick wants to merge 2 commits intoUserMcUser:masterfrom
--oldVersion and parse VersionPacket, support Artemis up to 2.8.x#3NoseyNick wants to merge 2 commits intoUserMcUser:masterfrom
Conversation
Author
|
Hey @UserMcUser , interested in updating with these patches? |
NoseyNick
commented
Dec 22, 2022
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/UserMcUser/node-MVM" | ||
| "url": "https://github.com/NoseyNick/node-MVM" |
Author
There was a problem hiding this comment.
Oh this you are obviously more than welcome to edit back to your URL of course! 😆
Owner
|
That's fine, I'm cool with it. 😎
My gaming group kinda stopped playing Artemis a while ago and I don't particularly have the time to work on this any more so please feel free to fork the code and continue with any mods or adjustments. I'd appreciate a shout-out in there somewhere but it's not required.
As far as I am able to do so (I did lift almost all of the code from another GitHub project!) I release all of the code to the public domain. 👍
I'm just glad that anyone else found it useful enough to continue to work on it. 😀
Thanks!
--
Steven Hunter | ***@***.***
I'm either going to live forever or die trying.
On Wednesday, December 21, 2022 at 11:32:49 PM EST, Nosey Nick ***@***.***> wrote:
@NoseyNick commented on this pull request.
In package.json:
- "url": "https://github.com/UserMcUser/node-MVM"
+ "url": "https://github.com/NoseyNick/node-MVM"
Oh this you are obviously more than welcome to edit back to your URL of course! 😆
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Author
Oh absolutely. Same place you gave a shout-out to //Based almost entirely on "tcpslow" by llambda - https://github.com/llambda/tcpslow
//UserMcUser just removed the "slow" parts and shoe-horned MVM code into the loop.
//NoseyNick obsoleted --oldVersion by parsing server version, support Artemis 2.8.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added support to parse VersionPacket...
... then no need for
--oldVersionThen added support up to Artemis 2.8.0 and probably 2.8.1
Other bits of code tidying.
Resolves #2 ... I believe