Modify rotation to prevent download errors#1779
Open
Saira-A wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@github-actions[bot] is attempting to deploy a commit to the Universal Viewer Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if an image is rotated right four times so it's back at it's original orientation, the URL generated when download is requested will contain a rotation value of 360 rather than zero. Though 360 and 0 are visually the same, IIIF image servers tend to throw errors at 360, e.g:
https://bl.digirati.io/images/ark:/81055/man_10000049.0x000018/full/1553,/360/default.jpg
https://iiif.wellcomecollection.org/image/b18035723_0001.JP2/full/2569,/360/default.jpg
https://iiif.library.villanova.edu/image/vudl%3A92894/full/691,1000/360/default.jpg
The same URLs work if 360 is replaced with 0. This PR uses modulo 360 so that the rotation will reset from 270 to 0 instead of 360 and a working URL is provided.