Add config and githubapp test coverage#4
Merged
Conversation
Config coverage: 49% → 93.3% (Load, applyDefaults, DefaultConfig, ParseRepo edge cases, env var overrides, validation boundaries). GitHubApp coverage: 44% → 82.3% (ListInstallations, GetInstallationToken, ListRepos with httptest mock servers, error paths). Make githubapp.App.baseURL configurable for testability. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Load(valid file, missing file, invalid YAML, validation errors, env var overrides),applyDefaults,DefaultConfig,ParseRepoedge cases (unknown host, two-part path),DefaultConfigPath, port bounds validationListInstallations,GetInstallationToken,ListReposusinghttptest.NewServermock HTTP servers, including success, error, and empty response pathsgithubapp.App.baseURLconfigurable (unexported field) for testabilityUnityInFlow/homebrew-tapGitHub repository for future Homebrew formula distributionTest plan
go test ./internal/config/ -cover→ 93.3%go test ./internal/githubapp/ -cover→ 82.3%go test ./... -count=1— all packages passgo vet ./...— clean🤖 Generated with Claude Code