simple PR to get this project building with the new Spago#41
Open
afcondon wants to merge 1 commit intoUnisay:mainfrom
Open
simple PR to get this project building with the new Spago#41afcondon wants to merge 1 commit intoUnisay:mainfrom
afcondon wants to merge 1 commit intoUnisay:mainfrom
Conversation
Migrate the test PureScript project to use the new spago.yaml format, enabling compatibility with spago 0.93+ which dropped support for dhall-based configuration. Changes: - Add test/ps/spago.yaml with extraPackages pointing to Lua-compatible forks (purescript-lua-prelude, purescript-lua-effect, etc.) - Update Golden/Spec.hs to use `spago build` instead of the deprecated `spago build -u '-g corefn'` (new spago generates corefn by default) - Update .gitignore to exclude spago build artifacts (library dependencies) while keeping Golden.* test directories - Regenerate golden files with updated package versions The Lua-compatible packages are sourced from: - https://github.com/Unisay/purescript-lua-* - https://github.com/purescript-lua/purescript-lua-* Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Owner
|
Thanks for PRs, I'll be reviewing them once I have a bit more spare time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full disclosure, I, Andrew, had Claude, an LLM, do this work and prepare the PR. However, i am using the resulting PureScript Lua build now and it is working fine in my limited examples.
Migrate the test PureScript project to use the new spago.yaml format, enabling compatibility with spago 0.93+ which dropped support for dhall-based configuration.
Changes:
spago buildinstead of the deprecatedspago build -u '-g corefn'(new spago generates corefn by default)The Lua-compatible packages are sourced from: