feat(storybook): add chart stories with Apollo theme colors#666
Draft
1980computer wants to merge 5 commits into
Draft
feat(storybook): add chart stories with Apollo theme colors#6661980computer wants to merge 5 commits into
1980computer wants to merge 5 commits into
Conversation
Add 7 individual chart story files under Components/Charts/ (Area, Bar, Line, Pie, Radar, Radial, Tooltips) with 2-3 variants each extracted from the Maestro visualization template. Update the All Components gallery with a Charts category section using real mini Recharts renders as preview tiles. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… in sidebar Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Split THEMES in chart.tsx to 4 keys (light, dark, future-light, future-dark) so each theme gets the correct color token. Add chart-palette.ts with slot-based hex values for core themes and var(--chart-N) vars for future themes. Update all chart story configs and the visualization template to use the new palette. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ed hex Replace hardcoded hex values in chart-palette.ts and visualization palette with var(--color-chart-*, fallback) so each theme automatically resolves its own color token. Light-HC now shows the correct high-contrast values instead of sharing the regular-light hex. Future Light/Dark continue to use var(--chart-N) as before. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Map --color-chart-* token names to --chart-N vars inside the future-light and future-dark theme blocks so the CSS custom property chain resolves correctly for all themes without requiring a JS recompile. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency License Review
License distribution
Excluded packages
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chart-palette.tswith slot-based color palette wired to Apollo core chart tokensTHEMESinchart.tsxto 4 keys (light,dark,future-light,future-dark) so each theme resolves the correct color tokens--color-chart-*) into future theme blocks intailwind.consumer.cssStatus
Draft — chart bar colors in Future Dark/Light themes need further debugging. The CSS custom property chain is set up correctly but bars are still rendering as black in Storybook. Coming back to resolve once Storybook rendering is confirmed working.
Test plan
🤖 Generated with Claude Code