feat(apollo-vertex): extend data-table with plain option#655
Open
tarasiuk-o wants to merge 2 commits intomainfrom
Open
feat(apollo-vertex): extend data-table with plain option#655tarasiuk-o wants to merge 2 commits intomainfrom
tarasiuk-o wants to merge 2 commits intomainfrom
Conversation
tarasiuk-o
requested review from
0xr3ngar and
ruudandriessen
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency License Review
License distribution
Excluded packages
|
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a plain option to the apollo-vertex DataTable to allow rendering without the GLASS_CLASSES styling.
Changes:
- Extended
DataTablePropswith a new optionalplain?: booleanprop. - Defaulted
plaintofalsein the component signature. - Conditionally applied
GLASS_CLASSESbased onplain.
0xr3ngar
requested changes
May 7, 2026
| renderExpandedRow, | ||
| getRowClassName, | ||
| skeletonColumnWidths, | ||
| plain = false, |
Collaborator
There was a problem hiding this comment.
what does plain mean, can we give it a better name?
Contributor
Author
There was a problem hiding this comment.
@0xr3ngar If the constant is named GLASS_CLASSES, we can make the option name clearer — for example, a boolean glass, a union variant: "glass" | "plain", glassClasses, or transparent.
The core issue is that we need a way to render the data table without GLASS_CLASSES. WDYT?
Collaborator
There was a problem hiding this comment.
Why do we want to render it without? This is the current design no?
Collaborator
There was a problem hiding this comment.
When data tables are the main item in a page (eg our loans table view), glass class is appropriate. Sometimes we need a data table without the glass class when it's inside a another container in a page (and having the glass classes would be too much).
ruudandriessen
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
plainprop to render table withoutGLASS_CLASSES