Skip to content

feat(apollo-vertex): shell component cleanup and MRS alignment#537

Merged
KokoMilev merged 1 commit into
mainfrom
creilly11235/vertex-shell-cleanup
Apr 20, 2026
Merged

feat(apollo-vertex): shell component cleanup and MRS alignment#537
KokoMilev merged 1 commit into
mainfrom
creilly11235/vertex-shell-cleanup

Conversation

@creilly11235
Copy link
Copy Markdown
Contributor

Summary

  • Refactor shell-company with explicit isCustom boolean (replaces unreliable !darkUrl heuristic)
  • Simplify shell-language-toggle implementation
  • Swap shell-login to vertex Button component
  • Remove dead shell-theme-toggle component (logic lives in UserProfileMenuItems)
  • Update SVG logos and locale key

Split from #468 — this is the foundational cleanup needed before animation work.

Test plan

  • Company logo renders correctly with custom and default logos
  • Language toggle works in both sidebar and minimal header
  • Login button renders with vertex Button styling
  • No regressions in shell layout

🤖 Generated with Claude Code

@creilly11235 creilly11235 requested a review from a team as a code owner April 18, 2026 01:24
@creilly11235 creilly11235 requested review from VKravchuk and frankkluijtmans and removed request for a team April 18, 2026 01:24
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (PT)
apollo-design 🟢 Ready Preview, Logs Apr 17, 2026, 06:51:55 PM
apollo-docs 🟢 Ready Preview, Logs Apr 17, 2026, 06:50:56 PM
apollo-landing 🟢 Ready Preview, Logs Apr 17, 2026, 06:50:22 PM
apollo-ui-react 🟢 Ready Preview, Logs Apr 17, 2026, 06:50:28 PM
apollo-vertex 🟢 Ready Preview, Logs Apr 17, 2026, 06:51:37 PM

@github-actions
Copy link
Copy Markdown

Dependency License Review

  • 1941 package(s) scanned
  • ✅ No license issues found
  • ⚠️ 3 package(s) excluded (see details below)
License distribution
License Packages
MIT 1701
ISC 89
Apache-2.0 61
BSD-3-Clause 28
BSD-2-Clause 23
BlueOak-1.0.0 8
MPL-2.0 5
MIT OR Apache-2.0 3
MIT-0 3
CC0-1.0 3
LGPL-3.0-or-later 2
(MIT OR Apache-2.0) 2
Unlicense 2
Python-2.0 1
CC-BY-4.0 1
(MPL-2.0 OR Apache-2.0) 1
Unknown 1
Artistic-2.0 1
(WTFPL OR MIT) 1
(BSD-2-Clause OR MIT OR Apache-2.0) 1
CC-BY-3.0 1
0BSD 1
(MIT OR CC0-1.0) 1
MIT AND ISC 1
Excluded packages
Package Version License Reason
@img/sharp-libvips-linux-x64 1.2.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
@img/sharp-libvips-linuxmusl-x64 1.2.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
khroma 2.1.0 Unknown MIT per GitHub repo, missing license field in package.json

@creilly11235 creilly11235 force-pushed the creilly11235/vertex-shell-cleanup branch 2 times, most recently from 07c279f to 7f016b8 Compare April 18, 2026 01:41
- Refactor shell-company with explicit isCustom boolean
- Add isCustom to CompanyLogo interface in shell.tsx
- Simplify shell-language-toggle
- Swap shell-login to vertex Button component
- Remove dead shell-theme-toggle component
- Update SVG logos and locale key

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@creilly11235 creilly11235 force-pushed the creilly11235/vertex-shell-cleanup branch from 7f016b8 to 2338db8 Compare April 18, 2026 01:49
@KokoMilev KokoMilev merged commit e88b0b4 into main Apr 20, 2026
47 checks passed
@KokoMilev KokoMilev deleted the creilly11235/vertex-shell-cleanup branch April 20, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:apollo-vertex size:L 100-499 changed lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants