Fix various STOW-RS issues#57
Conversation
There was a problem hiding this comment.
Just a suggestion how we test against external systems (from our BitBucket pipelines):
services:
orthanc: # DICOMweb server for testing
memory: 256
image: jodogne/orthanc-pluginsWe usually let Orthanc or other docker services run as part of the pipeline. GH has a similar feature https://docs.github.com/en/actions/tutorials/use-containerized-services/use-docker-service-containers
Running tests locally would be less convenient then however
There was a problem hiding this comment.
Is there a reason the testcontainers approach wouldn’t work for you?
It should work in most CI environments, as long as Docker is available at test time.
As you can see here, the GitHub Actions runner successfully executed the integration tests.
There was a problem hiding this comment.
It was just an idea to reduce rust code that needs to be maintained, but both variants work of course :)
Instead of printing server.port=0 when setting server.http.port to 0, this will now log the actual port.
b987dcc to
1ec72e8
Compare
This pull request addresses several STOW-RS issues that were reported in #55 and #56.
max-upload-size.