Proto conversion name consistency#3664
Open
maggiettu wants to merge 16 commits intoUBC-Thunderbots:masterfrom
Open
Proto conversion name consistency#3664maggiettu wants to merge 16 commits intoUBC-Thunderbots:masterfrom
maggiettu wants to merge 16 commits intoUBC-Thunderbots:masterfrom
Conversation
maggiettu
requested review from
Andrewyx,
sauravbanna and
williamckha
as code owners
StarrryNight
reviewed
Apr 4, 2026
| @@ -100,7 +100,7 @@ void UnixSimulatorBackend::onValueReceived(World world) | |||
| { | |||
| world_output->sendProto(*createWorldWithSequenceNumber(world, sequence_number++)); | |||
Contributor
There was a problem hiding this comment.
'createWorldWithSequenceNumberProto'
StarrryNight
reviewed
Apr 4, 2026
Contributor
StarrryNight
left a comment
StarrryNight
left a comment
There was a problem hiding this comment.
Nice work! Tests are failing because there are some function calls yet to be renamed. Try using search everywhere to find remaining functions to change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Renamed all the proto conversion functions to have proto in the name, as well as all their use cases
Testing Done
Resolved Issues
#2901
Length Justification and Key Files to Review
N/A
Review Checklist
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue