Use relative paths for workspace items#1
Open
mauricerkelly wants to merge 1 commit intoTurfDb:masterfrom
mauricerkelly:relative-paths-in-workspace
Open
Use relative paths for workspace items#1mauricerkelly wants to merge 1 commit intoTurfDb:masterfrom mauricerkelly:relative-paths-in-workspace
mauricerkelly wants to merge 1 commit intoTurfDb:masterfrom
mauricerkelly:relative-paths-in-workspace
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When looking at the
Playgrounds.xcworkspacefile, I noticed that theTurfproject, theBasicplayground and theBasicObservablesplayground references were not functioning.I've "repaired" the playgrounds by using relative links instead of absolute. For the
Turfproject, I made an assumption that the user will have theTurfandPlaygroundsrepos checked out side by side, and so I've used a relative link from thePlaygroundsfolder to../Turf. Could always use submodules or something to make it slightly more flexible?'Grats on the project BTW!