Conversation
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on April 3. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughA new Turkish translation file ( Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Using "yazı" for post is more natural and aligns with Sodo Search translation
flightlesstux
left a comment
There was a problem hiding this comment.
Code Review: Turkish (tr) translations
Overview: Adds a new tr.json locale file to packages/theme-translations/locales/ with 112 Turkish translations for Ghost themes. Pure addition, no existing code modified.
Positive Aspects
- Complete coverage — all keys from the shared translations appear to be present
- Natural Turkish phrasing (intentional departures from literal translation, which is correct for UX)
- Proper use of placeholders (
{authors},{numberOfIssues},%, etc.) preserved correctly - Good handling of Turkish-specific characters (ş, ğ, ü, ö, ı, ç) — UTF-8 encoded correctly
Suggestions & Observations
Terminology consistency:
"Sign in"→"Giriş yap"and"Login"→"Giriş yap"— both map to the same translation. Fine since Turkish doesn't differentiate, intentionally identical."Sign in."(with period) →"Giriş yap."— correctly preserves punctuation.
Potentially debatable translations:
"issue"/"issues"→"sayı"/"sayılar"— "sayı" is the correct publishing term (magazine issue), good choice."Toggle menu"→"Menüyü değiştir"— "değiştir" means "change/switch", technically correct but"Menüyü aç/kapat"might be more intuitive for a toggle action."Toggle fullscreen"→"Tam ekran yap"— loses the toggle aspect (enter/exit)."Tam ekran geçiş"would be more accurate."Password"→"Şifre"— correct, though"Parola"is also widely used and considered more standard in modern Turkish UIs (Apple, Google TR). Minor preference.
Placeholder email localization:
"jamie@example.com"→"bilge@ornek.com"— Nice touch localizing to a Turkish name/domain.
Structural:
- Valid JSON, well-indented (4 spaces, consistent with other locale files)
- No missing or extra keys
Verdict
Looks good with minor comments. Two items worth considering:
"Toggle menu"/"Toggle fullscreen"translations lose the bidirectional toggle semantics"Şifre"vs"Parola"— minor UX preference, not a blocker
No correctness issues, no security concerns, no structural problems.
|
Thank you @flightlesstux. Fair points. I changed "Toggle .." translations and switched to "Parola" for "Password". |
Here is the Turkish translations for all shared texts for the themes. In some places, I tried to use more natural usage in Turkish instead of direct translations.