Moved 21 consistent direct deps into the default pnpm catalog#27876
Open
9larsons wants to merge 1 commit into
Open
Moved 21 consistent direct deps into the default pnpm catalog#278769larsons wants to merge 1 commit into
9larsons wants to merge 1 commit into
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (20)
✅ Files skipped from review due to trivial changes (4)
🚧 Files skipped from review as they are similar to previous changes (16)
WalkthroughThis PR introduces a pnpm workspace catalog in Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #27876 +/- ##
=======================================
Coverage 73.79% 73.79%
=======================================
Files 1519 1519
Lines 128104 128104
Branches 15355 15355
=======================================
+ Hits 94531 94533 +2
+ Misses 32642 32617 -25
- Partials 931 954 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9larsons
force-pushed
the
deps-catalog-batch-a
branch
from
1959a1c to
68de7eb
Compare
9larsons
changed the title
9larsons
changed the title
- 21 deps were declared at the exact same version across 4-13 workspaces (typescript, jsdom, @playwright/test, @types/react, @types/react-dom, @vitejs/plugin-react, @tanstack/react-query, @typescript-eslint/parser, @sentry/react, @tryghost/debug, c8, clsx, concurrently, eslint-plugin-react-refresh, postcss, sonner, validator, zod, vite, vitest, vite-plugin-svgr) — pure centralization candidates - centralizing in pnpm-workspace.yaml means Renovate (and humans) bump one entry per dep instead of N package.jsons, and prevents future accidental drift - no resolved version changes: every catalog entry matches the version every consuming workspace already had pinned; lockfile diff is only catalog metadata + a few unrelated transitive dedupes - excluded drifted deps (react, tailwindcss, @testing-library/*, @types/node, @vitest/coverage-v8, glob, sinon, etc.) which need version negotiation or model intentional splits like the existing eslint9 named catalog — those land separately
9larsons
force-pushed
the
deps-catalog-batch-a
branch
from
86279b0 to
37e7f1e
Compare
9larsons
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Centralizes 21 direct dependencies that were already declared at the exact same version across 4–13 workspaces into the default `catalog:` block in `pnpm-workspace.yaml`. Every consuming `package.json` now references the dep as `"foo": "catalog:"` instead of repeating the version.
Why
No resolved versions change
Every catalog entry matches the version every consuming workspace already had pinned. Verified before applying that all 21 deps had exactly one distinct version string across all consumers. The `pnpm-lock.yaml` diff is catalog metadata plus a few unrelated transitive de-dupes from regeneration.
Out of scope