Skip to content

net 10 upgrade completed#1471

Merged
StuartFerguson merged 9 commits intomasterfrom
task/#1423_net_10_upgrade
Dec 11, 2025
Merged

net 10 upgrade completed#1471
StuartFerguson merged 9 commits intomasterfrom
task/#1423_net_10_upgrade

Conversation

@StuartFerguson
Copy link
Member

closes #1466
closes #1462
closes #1423

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI 2 months ago

General fix:
Explicitly set the permissions key either at the workflow root (affecting all jobs that do not have their own permissions block) or for each job individually. Set the minimal permissions required for the job(s). If unsure of minimal permissions, use contents: read as a securing default, then escalate only as required for specific steps (e.g., pull-requests: write if modifying PRs).

Best specific fix:
Because the flag was highlighted at the deployproduction job (starting at line 111), and to avoid potential impacts on job inheritance, it makes sense to add a permissions: {} block to the deployproduction job, explicitly limiting the token permissions to none unless further privileges are required by steps in this job.

Implementation steps:

  • Add permissions: {} as the first property under the deployproduction: job definition (just after line 111).
  • No new methods, imports, or variable definitions are required; this is a YAML structure-only change.

Suggested changeset 1
.github/workflows/createrelease.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/createrelease.yml b/.github/workflows/createrelease.yml
--- a/.github/workflows/createrelease.yml
+++ b/.github/workflows/createrelease.yml
@@ -109,6 +109,7 @@
 
   deployproduction:
     runs-on: [productionserver, windows]
+    permissions: {}
     needs: [build, deploystaging]
     environment: production
     name: "Deploy to Production"
EOF
@@ -109,6 +109,7 @@

deployproduction:
runs-on: [productionserver, windows]
permissions: {}
needs: [build, deploystaging]
environment: production
name: "Deploy to Production"
Copilot is powered by AI and may make mistakes. Always verify output.
@StuartFerguson StuartFerguson merged commit 0343c12 into master Dec 11, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Shared Nugets Move to Windows Release Workflow Net 10 Upgrade

1 participant