Skip to content

BuildViewModel refactoring #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StuartFerguson merged 2 commits into from
Dec 27, 2025
Merged

BuildViewModel refactoring #1031

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d8b824
BuildViewModel refactoring
StuartFerguson Dec 27, 2025
f3ee7e7
Merge branch 'master' into task/#867_reduce_complexity
StuartFerguson Dec 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
132 changes: 90 additions & 42 deletions SecurityService.UserInterface/Pages/Account/Login/Index.cshtml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,70 +146,118 @@ private async Task<IActionResult> HandleLoginButton(AuthorizationRequest? contex

private async Task BuildModelAsync(string returnUrl)
{
Input = new InputModel
Input = CreateInputModel(returnUrl);

var context = await _interaction.GetAuthorizationContextAsync(returnUrl);

if (await TryBuildSingleIdpViewAsync(context))
return;

var providers = await GetExternalProvidersAsync(context?.Client);

View = CreateViewModel(context?.Client, providers);
}

private InputModel CreateInputModel(string returnUrl) =>
new()
{
ReturnUrl = returnUrl
};

var context = await _interaction.GetAuthorizationContextAsync(returnUrl);
if (context?.IdP != null && await _schemeProvider.GetSchemeAsync(context.IdP) != null)
{
var local = context.IdP == Duende.IdentityServer.IdentityServerConstants.LocalIdentityProvider;

// this is meant to short circuit the UI and only trigger the one external IdP
View = new ViewModel
{
EnableLocalLogin = local,
};
private async Task<bool> TryBuildSingleIdpViewAsync(AuthorizationRequest? context)
{
if (context?.IdP == null)
return false;

Input.Username = context?.LoginHint;
if (await _schemeProvider.GetSchemeAsync(context.IdP) == null)
return false;

if (!local)
{
View.ExternalProviders = new[] { new ViewModel.ExternalProvider { AuthenticationScheme = context.IdP } };
}
var isLocal = context.IdP == Duende.IdentityServer.IdentityServerConstants.LocalIdentityProvider;

return;
}
View = new ViewModel
{
EnableLocalLogin = isLocal,
ExternalProviders = isLocal
? Array.Empty<ViewModel.ExternalProvider>()
: new[]
{
new ViewModel.ExternalProvider
{
AuthenticationScheme = context.IdP
}
}
};

Input.Username = context.LoginHint;

return true;
}
private async Task<List<ViewModel.ExternalProvider>> GetExternalProvidersAsync(Client? client)
{
var providers = await GetStaticProvidersAsync();
providers.AddRange(await GetDynamicProvidersAsync());

return ApplyClientRestrictions(providers, client);
}

private async Task<List<ViewModel.ExternalProvider>> GetStaticProvidersAsync()
{
var schemes = await _schemeProvider.GetAllSchemesAsync();

var providers = schemes
.Where(x => x.DisplayName != null)
.Select(x => new ViewModel.ExternalProvider
return schemes
.Where(s => s.DisplayName != null)
.Select(s => new ViewModel.ExternalProvider
{
DisplayName = x.DisplayName ?? x.Name,
AuthenticationScheme = x.Name
}).ToList();
AuthenticationScheme = s.Name,
DisplayName = s.DisplayName!
})
.ToList();
}

private async Task<IEnumerable<ViewModel.ExternalProvider>> GetDynamicProvidersAsync()
{
var schemes = await _identityProviderStore.GetAllSchemeNamesAsync();

var dyanmicSchemes = (await _identityProviderStore.GetAllSchemeNamesAsync())
.Where(x => x.Enabled)
.Select(x => new ViewModel.ExternalProvider
return schemes
.Where(s => s.Enabled)
.Select(s => new ViewModel.ExternalProvider
{
AuthenticationScheme = x.Scheme,
DisplayName = x.DisplayName
AuthenticationScheme = s.Scheme,
DisplayName = s.DisplayName
});
providers.AddRange(dyanmicSchemes);
}

private List<ViewModel.ExternalProvider> ApplyClientRestrictions(
List<ViewModel.ExternalProvider> providers,
Client? client)
{
if (client == null)
return providers;

var allowLocal = true;
var client = context?.Client;
if (client != null)
{
allowLocal = client.EnableLocalLogin;
if (client.IdentityProviderRestrictions != null && client.IdentityProviderRestrictions.Any())
{
providers = providers.Where(provider => client.IdentityProviderRestrictions.Contains(provider.AuthenticationScheme)).ToList();
}
Input.ClientId = client.ClientId;

Input.ClientId = client.ClientId;
if (client.IdentityProviderRestrictions?.Any() == true)
{
providers = providers
.Where(p => client.IdentityProviderRestrictions.Contains(p.AuthenticationScheme))
.ToList();
}

View = new ViewModel
return providers;
}

private ViewModel CreateViewModel(
Client? client,
IEnumerable<ViewModel.ExternalProvider> providers)
{
var allowLocal = client?.EnableLocalLogin ?? true;

return new ViewModel
{
AllowRememberLogin = LoginOptions.AllowRememberLogin,
EnableLocalLogin = allowLocal && LoginOptions.AllowLocalLogin,
ExternalProviders = providers.ToArray(),
ExternalProviders = providers.ToArray()
};
}

}
Loading