docs(skills): backport Flex lineage + manual-outreach pitfalls (v1.6.1)#11
Merged
Merged
Conversation
added 2 commits
May 14, 2026 11:16
GHL returns meta.startAfter as a JSON number (epoch ms). stringField returned "" for non-string types, silently dropping the cursor and breaking after page 1. Fix with anyToString helper that handles float64/int/json.Number (strconv.FormatFloat 'f',-1 to avoid scientific notation in the next request's query string). Also drop the len(list) < pageLimit early-break in syncContacts — GHL filters server-side, so a short page can be followed by a full one. Trust the cursor as the only stop signal. Adds pagination_test.go as a regression guard.
…dled skills Promotes two pitfalls already in use in the sales_agent profile copy to the bundled hermes and claude-code skills, plus the supporting reference doc, and adds the missing `version` field to the claude-code variant so parity scripts see both at the same revision. Pitfalls: - "Treating current pipeline as historical origin" — current opportunities state is not proof of original pipeline; Flex triage→qualified questions need a lineage caveat unless a history/audit surface records the move. - "Counting automated workflow touches as rep effort" — manual outreach audits must exclude raw_payload.source = 'app' workflow automation and break out channel + contact counts separately. Both pitfalls fell out of live Paul audits and are now part of the canonical and per-profile skill copies; this PR brings the open-source bundled skills to the same v1.6.1 contract. No CLI behavior changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the bundled
skills/hermesandskills/claude-codeskills up to the v1.6.1 contract already running in the per-profile copies. Two pitfalls fell out of recent live Paul audits and are now canonical; this PR promotes them to the public bundled skills.What changes
Pitfalls added (both bundled variants):
opportunitiesstate is not proof of original pipeline lineage. For Flex triage → qualified conversion questions, answer current-state first, then add a lineage confidence caveat unless a history/audit surface records the move. Prevents "originated in Triage" claims based only on current pipeline = Qualified.raw_payload.source = 'app'workflow automation and break out call/email/SMS + contact counts separately.Reference doc promoted to bundled hermes:
skills/hermes/references/flex-crm-lineage-and-manual-outreach.md— Flex pipeline IDs, manual-outreach SQL patterns, lineage caveats, history-surface probe.Parity fix:
skills/claude-code/SKILL.mdnow carriesversion: 1.6.1(was missing the version field entirely).Why
Test plan