Theme Wipe Specialization and Visual Fixes#22
Conversation
- Strictly limit Puppeteer snapshots to home (`/`, `/tim`, `/tiger`) and projects listing pages. - Implement multi-tier fallback (Puppeteer -> modern-screenshot -> Instant) for all other routes. - Remove scrollbar-gutter logic to eliminate the "yellow fake scrollbar" artifact. - Fix snapshot coverage by using `bg-[length:100%_100%]` and capturing `window.innerWidth`. - Improve mask capture timing to prevent theme flashing during heavy background tasks. - Align the wipe divider line accurately to the clip-path edge using percentage-based positioning. - Improve DOM serialization to handle theme overrides and remove ignored elements.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This change optimizes the theme transition experience by specializing the snapshot strategy based on the page type and fixing several visual regressions.
Key improvements:
100% 100%scaling in the overlay andwindow.innerWidthfor capture, encompassing the entire viewport including scrollbar tracks.translate: 0 -50%and percentage-based vertical movement, ensuring it matches the container bounds regardless of viewport size.scrollbar-gutterhack as requested, and improved the DOM serializer to fully remove excluded elements (data-html2canvas-ignore, scripts, etc.) from the payload, reducing snapshot API overhead.PR created automatically by Jules for task 16427792831135789730 started by @TimChinye