Skip to content

Theme Wipe Transition Improvements#21

Draft
TimChinye wants to merge 1 commit intofix-browserless-concurrency-limits-11555592774675683851from
feature/theme-wipe-improvements-2-16427792831135789730
Draft

Theme Wipe Transition Improvements#21
TimChinye wants to merge 1 commit intofix-browserless-concurrency-limits-11555592774675683851from
feature/theme-wipe-improvements-2-16427792831135789730

Conversation

@TimChinye
Copy link
Owner

This change improves the theme transition experience by optimizing the snapshot methods used for different pages and fixing visual bugs in the wipe animation.

Key improvements:

  • Targeted Puppeteer Usage: Only the homepage and projects page use the more expensive Puppeteer-based snapshots. Other pages fallback to client-side snapshots immediately to save resources and improve speed.
  • Visual Fidelity: Fixed a gap at the bottom of the screen during transitions and ensured snapshots don't squash content by using correct CSS background sizing (100% auto anchored to the top).
  • Clean Transitions: Removed the scrollbar-gutter hack which was causing a "yellow fake scrollbar" to appear on some devices.
  • Robustness: Enhanced the DOM serializer to explicitly force the target theme in the serialized HTML, ensuring distinct 'before' and 'after' snapshots even when captured sequentially.
  • Performance: Elements marked with data-html2canvas-ignore are now removed from the DOM during serialization to reduce payload size.

PR created automatically by Jules for task 16427792831135789730 started by @TimChinye

- Conditionalize Puppeteer usage: enabled for home and projects paths, disabled for others.
- Implement multi-tier fallback (Puppeteer -> modern-screenshot -> Instant).
- Remove scrollbar-gutter logic to eliminate the "yellow fake scrollbar" artifact.
- Fix snapshot coverage by using `bg-top bg-[length:100%_auto]` and `window.innerWidth`.
- Improve DOM serialization to handle theme overrides and remove ignored elements correctly.
@google-labs-jules
Copy link

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel
Copy link
Contributor

vercel bot commented Mar 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
portfolio Building Building Preview, Comment Mar 3, 2026 6:34pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant