Draft
Conversation
In the previous state, the generated C++ files were not really usable for gRPC. This commit fixes that: * Generate the gRPC service - before, only the message definitions were generated * Change the output directory to cpp/include/proto, so the include path can be set to cpp/include and header files can be imported like `#include <proto/management.pb.h>` * And, most impactful: Require a full gRPC installation under the set directory (~/.local/grpc) instead of just fetching the protoc binary. It turns out that just downloading the protoc release is not enough for C++, it requires the full installation, including libraries and protoc plugin. It also requires the generators protobuf version to match the applications protobuf version, which is most easily achieved by just using the same installation. So, there is no point in downloading the protoc release anymore as a full installation is required anyway (which includes the correct protoc binary).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the previous state, the generated C++ files were not really usable for gRPC. This commit fixes that:
#include <proto/management.pb.h>It turns out that just downloading the protoc release is not enough for C++, it requires the full installation, including libraries and protoc plugin. It also requires the generators protobuf version to match the applications protobuf version, which is most easily achieved by just using the same installation. So, there is no point in downloading the protoc release anymore as a full installation is required anyway (which includes the correct protoc binary).