Skip to content

Feature/task bench support#6876

Open
guptapratykshh wants to merge 8 commits intoTheHPXProject:masterfrom
guptapratykshh:feature/task_bench_support
Open

Feature/task bench support#6876
guptapratykshh wants to merge 8 commits intoTheHPXProject:masterfrom
guptapratykshh:feature/task_bench_support

Conversation

@guptapratykshh
Copy link
Copy Markdown
Contributor

Fixes #4274

Proposed Changes

  • added the full task-bench benchmark suite under examples/task_bench to evaluate runtime performance
  • implemented the hpx driver using hpx::experimental::for_loop and fork_join_executor for efficient task graph execution
  • integrated the benchmark into the main cmake build system so it builds with HPX_WITH_EXAMPLES=ON

Any background context you want to provide?

Checklist

Not all points below apply to all pull requests.

  • I have added a new feature and have added tests to go along with it.
  • I have fixed a bug and have added a regression test.
  • I have added a test using random numbers; I have made sure it uses a seed, and that random numbers generated are valid inputs for the tests.

@StellarBot
Copy link
Copy Markdown

Can one of the admins verify this patch?

@guptapratykshh guptapratykshh force-pushed the feature/task_bench_support branch 9 times, most recently from 8b98668 to 76253cb Compare February 4, 2026 11:04
Copy link
Copy Markdown
Contributor

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guptapratykshh Did you implement the HPX version of task_bench?

@guptapratykshh
Copy link
Copy Markdown
Contributor Author

Yes, i am working on HPX implementation, utilizing hpx::execution::experimental::fork_join_executor to efficiently handle intra node parallelism for task graph

@hkaiser
Copy link
Copy Markdown
Contributor

hkaiser commented Feb 5, 2026

Yes, i am working on HPX implementation, utilizing hpx::execution::experimental::fork_join_executor to efficiently handle intra node parallelism for task graph

Thanks! The only thing I'm unsure of is whether we really should add the whole task_bench code base to our repository. Wouldn't it be better to upstream your changes to them?

@guptapratykshh
Copy link
Copy Markdown
Contributor Author

@hkaiser, you are right, i have upstreamed the implementation to task bench - StanfordLegion/task-bench#101
once that is merged, i will update this pr to remove duplicated task bench code from HPX and add minimal example that uses task bench as an external dependency

@hkaiser hkaiser added this to the 2.0.0 milestone Mar 28, 2026
@hkaiser
Copy link
Copy Markdown
Contributor

hkaiser commented Mar 28, 2026

@guptapratykshh I'm going to close this without merging. Please re-open if you feel that we will pursue this PR any further.

@hkaiser hkaiser closed this Mar 28, 2026
@guptapratykshh
Copy link
Copy Markdown
Contributor Author

@hkaiser now we should re-open this PR as this StanfordLegion/task-bench#101 is merged as well as the race condition(StanfordLegion/task-bench#94 (comment)) has also been fixed in that PR

@hkaiser hkaiser reopened this Apr 14, 2026
@hkaiser
Copy link
Copy Markdown
Contributor

hkaiser commented Apr 14, 2026

@guptapratykshh when pushing to this PR, please remove the task-bench code by force-pushing to remove it completely from the git history.

@codacy-production
Copy link
Copy Markdown

codacy-production bot commented Apr 14, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

@guptapratykshh guptapratykshh force-pushed the feature/task_bench_support branch from e014ade to 464f5de Compare April 14, 2026 16:45
@guptapratykshh guptapratykshh changed the title [Draft] [WIP] Feature/task bench support Feature/task bench support Apr 14, 2026
@guptapratykshh guptapratykshh marked this pull request as ready for review April 14, 2026 16:50
Copilot AI review requested due to automatic review settings April 14, 2026 16:50
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds TaskBench benchmark support to the HPX examples by integrating an external TaskBench checkout and building HPX TaskBench driver executables as part of the examples build.

Changes:

  • Introduces examples/task_bench CMake logic that fetches TaskBench and builds the core library + HPX driver executables.
  • Adds task_bench to the top-level examples subdirectory list so it is built when examples are enabled.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.

File Description
examples/task_bench/CMakeLists.txt Fetches upstream TaskBench and defines build targets for TaskBench core + HPX drivers.
examples/CMakeLists.txt Registers task_bench as an examples subdirectory.

Comment thread examples/task_bench/CMakeLists.txt
Comment thread examples/task_bench/CMakeLists.txt
Comment thread examples/task_bench/CMakeLists.txt
Comment thread examples/task_bench/CMakeLists.txt
Comment thread examples/CMakeLists.txt
Comment thread examples/task_bench/CMakeLists.txt
Comment thread examples/task_bench/CMakeLists.txt Outdated
Comment thread examples/task_bench/CMakeLists.txt
Copilot AI review requested due to automatic review settings April 14, 2026 17:37
@guptapratykshh guptapratykshh force-pushed the feature/task_bench_support branch from 20c5f35 to 302334a Compare April 14, 2026 17:37
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment thread examples/task_bench/CMakeLists.txt
Comment thread examples/task_bench/CMakeLists.txt
Copilot AI review requested due to automatic review settings April 14, 2026 17:59
@guptapratykshh guptapratykshh force-pushed the feature/task_bench_support branch from ca8969a to c0a3603 Compare April 14, 2026 17:59
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

Comment thread examples/task_bench/CMakeLists.txt
Comment thread examples/task_bench/CMakeLists.txt
Comment thread examples/task_bench/CMakeLists.txt
Copilot AI review requested due to automatic review settings April 14, 2026 19:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

Comment thread examples/task_bench/CMakeLists.txt Outdated
Comment thread examples/task_bench/CMakeLists.txt
Comment thread examples/task_bench/CMakeLists.txt
Comment thread examples/task_bench/CMakeLists.txt
Copilot AI review requested due to automatic review settings April 15, 2026 04:31
@guptapratykshh guptapratykshh force-pushed the feature/task_bench_support branch from 211e50d to f4b86a5 Compare April 15, 2026 04:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

Comment thread examples/task_bench/CMakeLists.txt
Comment thread examples/task_bench/CMakeLists.txt
Comment thread examples/task_bench/CMakeLists.txt
Comment thread examples/task_bench/CMakeLists.txt
Comment thread examples/task_bench/CMakeLists.txt
Copilot AI review requested due to automatic review settings April 15, 2026 05:09
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

Comment thread examples/task_bench/CMakeLists.txt
Comment thread examples/task_bench/CMakeLists.txt
Comment thread examples/task_bench/CMakeLists.txt
Comment thread examples/task_bench/CMakeLists.txt
Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>
Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>
Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>
Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>
Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>
Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>
Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>
Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>
@guptapratykshh guptapratykshh force-pushed the feature/task_bench_support branch from aed6eb3 to 4b57333 Compare April 16, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Task-Bench (potentially as a GSoC project)

4 participants