Feature/task bench support#6876
Conversation
|
Can one of the admins verify this patch? |
8b98668 to
76253cb
Compare
hkaiser
left a comment
There was a problem hiding this comment.
@guptapratykshh Did you implement the HPX version of task_bench?
|
Yes, i am working on HPX implementation, utilizing hpx::execution::experimental::fork_join_executor to efficiently handle intra node parallelism for task graph |
Thanks! The only thing I'm unsure of is whether we really should add the whole task_bench code base to our repository. Wouldn't it be better to upstream your changes to them? |
|
@hkaiser, you are right, i have upstreamed the implementation to task bench - StanfordLegion/task-bench#101 |
|
@guptapratykshh I'm going to close this without merging. Please re-open if you feel that we will pursue this PR any further. |
|
@hkaiser now we should re-open this PR as this StanfordLegion/task-bench#101 is merged as well as the race condition(StanfordLegion/task-bench#94 (comment)) has also been fixed in that PR |
|
@guptapratykshh when pushing to this PR, please remove the task-bench code by force-pushing to remove it completely from the git history. |
Up to standards ✅🟢 Issues
|
e014ade to
464f5de
Compare
There was a problem hiding this comment.
Pull request overview
Adds TaskBench benchmark support to the HPX examples by integrating an external TaskBench checkout and building HPX TaskBench driver executables as part of the examples build.
Changes:
- Introduces
examples/task_benchCMake logic that fetches TaskBench and builds the core library + HPX driver executables. - Adds
task_benchto the top-level examples subdirectory list so it is built when examples are enabled.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| examples/task_bench/CMakeLists.txt | Fetches upstream TaskBench and defines build targets for TaskBench core + HPX drivers. |
| examples/CMakeLists.txt | Registers task_bench as an examples subdirectory. |
20c5f35 to
302334a
Compare
ca8969a to
c0a3603
Compare
211e50d to
f4b86a5
Compare
Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>
Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>
Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>
Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>
Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>
Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>
Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>
Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>
aed6eb3 to
4b57333
Compare
Fixes #4274
Proposed Changes
Any background context you want to provide?
Checklist
Not all points below apply to all pull requests.