Transition SR tag_invoke to member functions#6709
Open
isidorostsa wants to merge 4 commits intoTheHPXProject:prepare-v2.0.0from
Open
Transition SR tag_invoke to member functions#6709isidorostsa wants to merge 4 commits intoTheHPXProject:prepare-v2.0.0from
isidorostsa wants to merge 4 commits intoTheHPXProject:prepare-v2.0.0from
Conversation
c7b0044 to
d8a5414
Compare
a86a1ee to
2d58cc3
Compare
d8a5414 to
4561a4c
Compare
4561a4c to
ea93afb
Compare
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesFootnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P2300 has moved away from the tag_invoke design pattern, following the guidance in P2855. This PR removes tag_invoke support from the P2300 CPOs used by our senders. However, sender-adapter CPOs can remain tag_invoke-friendly since they provide an operator() that internally calls tag_invoke. For example, when_all_vector must drop support for tag_invoke(set_value_t...), but the when_all_vector algorithm itself can still be implemented as a CPO using operator() that calls tag_invoke(when_all_vector_t) under the hood.
At present, the non-stdexec implementation of senders will not be updated to work without tag_invoke.