regress: update avx512.bin expected output for vcvtps2ph fix#237
Open
dscho wants to merge 1 commit intoTerraspace:v2.58from
Open
regress: update avx512.bin expected output for vcvtps2ph fix#237dscho wants to merge 1 commit intoTerraspace:v2.58from
dscho wants to merge 1 commit intoTerraspace:v2.58from
Conversation
Commit 8222333 ("fix vcvtps2ph in codegen, messed up SIB", 2025-07-31) corrected the EVEX encoding of vcvtps2ph instructions, but did not regenerate the regression test expected output. The avx512.asm test contains vcvtps2ph instructions at file offset 0x52E5 whose encoding changed from the old (broken) form to the correct one. The expected output file regress/exp/plain_bin/avx512.bin was last updated at commit a2cfe04, which predates the vcvtps2ph fix. Regenerate it from v2.58 so the regression test passes again. Assisted-by: Claude Opus 4.6 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to get onnx-runtime's assembler code to compile, I noticed that the regression tests fail, even without any changes. This PR fixes that.