Skip to content

Add haptic feedback when crossing media message boundaries #2203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dasmfm wants to merge 2 commits into
base: master
Choose a base branch
from
+26 −1
Open

Add haptic feedback when crossing media message boundaries #2203

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f654806
Add haptic feedback between media messages
dasmfm Jun 15, 2026
a8f6975
Initialize gallery boundary haptic state
dasmfm Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion submodules/GalleryUI/Sources/GalleryController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,6 +654,19 @@ public struct GalleryEntry {
}
}

private enum GalleryEntryBoundaryId: Equatable {
case message(UInt32)
case group(UInt32)
}

private func galleryEntryBoundaryId(_ entry: GalleryEntry) -> GalleryEntryBoundaryId {
if let groupId = entry.entry.message.groupInfo?.stableId {
return .group(groupId)
} else {
return .message(entry.entry.message.stableId)
}
}

private func galleryEntriesForMessageHistoryEntries(_ entries: [MessageHistoryEntry], mediaSubject: GalleryMediaSubject?) -> [GalleryEntry] {
var results: [GalleryEntry] = []
for entry in entries {
Expand Down Expand Up @@ -749,6 +762,8 @@ public class GalleryController: ViewController, StandalonePresentableController,
private let baseNavigationController: NavigationController?

private var hiddenMediaManagerIndex: Int?
private let boundaryHaptic = HapticFeedback()
private var currentBoundaryId: GalleryEntryBoundaryId?

private let actionInteraction: GalleryControllerActionInteraction?
private var performAction: (GalleryControllerInteractionTapAction) -> Void
Expand Down Expand Up @@ -816,6 +831,7 @@ public class GalleryController: ViewController, StandalonePresentableController,
}

self.titleView = GalleryTitleView(context: context, presentationData: self.presentationData)
self.boundaryHaptic.prepareTap()

super.init(navigationBarPresentationData: NavigationBarPresentationData(theme: GalleryController.darkNavigationTheme, strings: NavigationBarStrings(presentationStrings: self.presentationData.strings)))

Expand Down Expand Up @@ -1690,14 +1706,23 @@ public class GalleryController: ViewController, StandalonePresentableController,
}

self.galleryNode.pager.replaceItems(items, centralItemIndex: centralItemIndex)
if let centralItemIndex = centralItemIndex, centralItemIndex < self.entries.count {
self.currentBoundaryId = galleryEntryBoundaryId(self.entries[centralItemIndex])
}

self.galleryNode.pager.centralItemIndexUpdated = { [weak self] index in
if let strongSelf = self {
var hiddenItem: (MessageId, Media)?
if let index = index {
let entry = strongSelf.entries[index]
let message = strongSelf.entries[index].entry.message

let boundaryId = galleryEntryBoundaryId(entry)
if let currentBoundaryId = strongSelf.currentBoundaryId, currentBoundaryId != boundaryId {
strongSelf.boundaryHaptic.tap()
}
strongSelf.currentBoundaryId = boundaryId
strongSelf.boundaryHaptic.prepareTap()

strongSelf.centralEntryStableId = entry.stableId
if let selectedMedia = selectedMediaForMessage(message: message, mediaSubject: entry.mediaSubject) {
hiddenItem = (message.id, selectedMedia)
Expand Down