Skip to content

fix(goodies): cap gitcheatsheet header image height#138

Merged
TechWatching merged 2 commits intomainfrom
copilot/reduce-header-image-size
Apr 17, 2026
Merged

fix(goodies): cap gitcheatsheet header image height#138
TechWatching merged 2 commits intomainfrom
copilot/reduce-header-image-size

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 17, 2026

The header image on /goodies/gitcheatsheet was rendering at full container width with no height constraint, making it dominate the viewport (source asset is 3840×2160).

Changes

  • content/3.goodies/1.gitcheatsheet.md: add maxHeight: 400 to the image frontmatter, matching the pattern already used by mcp-servers.md. The goodie page template (app/pages/goodies/[slug].vue) already applies object-cover with the max-height style when this field is set, so no template changes are needed. The value 400 keeps the Git logo and "Git Cheat Sheet" text fully visible while still cutting the rendered image height roughly in half versus the original unconstrained display.
image:
  src: /goodies/gitcheatsheet.webp
  maxHeight: 400

Screenshot

@TechWatching
Copy link
Copy Markdown
Owner

@copilot we should see the text on the image. update to keep the text Git Cheat Sheet and the git logo more visible

…and title visible

Agent-Logs-Url: https://github.com/TechWatching/techwatching.dev/sessions/d68b5fd1-bf13-4519-b4f3-e886f8082070

Co-authored-by: TechWatching <15186176+TechWatching@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 17, 2026

@copilot we should see the text on the image. update to keep the text Git Cheat Sheet and the git logo more visible

Bumped maxHeight from 300 → 400 in a1047fb so object-cover no longer clips the top/bottom of the content band — the Git logo and "Git Cheat Sheet" text are now fully visible while the image is still roughly half its original height.

after

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • api.fontshare.com
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/techwatching.dev/techwatching.dev/node_modules/.bin/../nuxt/bin/nuxt.mjs dev (dns block)
  • api.fontsource.org
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/techwatching.dev/techwatching.dev/node_modules/.bin/../nuxt/bin/nuxt.mjs dev (dns block)
  • fonts.bunny.net
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/techwatching.dev/techwatching.dev/node_modules/.bin/../nuxt/bin/nuxt.mjs dev (dns block)
  • fonts.google.com
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/techwatching.dev/techwatching.dev/node_modules/.bin/../nuxt/bin/nuxt.mjs dev (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI requested a review from TechWatching April 17, 2026 14:40
@TechWatching TechWatching marked this pull request as ready for review April 17, 2026 17:00
Copilot AI review requested due to automatic review settings April 17, 2026 17:00
@TechWatching TechWatching merged commit 92c42e6 into main Apr 17, 2026
2 checks passed
@TechWatching TechWatching deleted the copilot/reduce-header-image-size branch April 17, 2026 17:00
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Caps the cover image height on the /goodies/gitcheatsheet page via frontmatter so the header image no longer dominates the viewport, leveraging the existing goodies page template behavior.

Changes:

  • Add image.maxHeight: 400 to the gitcheatsheet goodie frontmatter to constrain rendered cover height.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants