Skip to content

추천기능 메인화면 UI를 개발합니다.#328

Merged
dongglehada merged 9 commits intodevfrom
feat/#327-RecommendationFeature-main
May 6, 2026
Merged

추천기능 메인화면 UI를 개발합니다.#328
dongglehada merged 9 commits intodevfrom
feat/#327-RecommendationFeature-main

Conversation

@dongglehada
Copy link
Copy Markdown
Member

📌 이슈

✅ 작업 사항

MLSRecommendationFeature 모듈 세팅

  • MLSAuthFeature와 동일한 3-layer 모듈 구조 세팅
    • MLSRecommendationFeatureInterface : Factory 프로토콜 정의 (RecommendationMainFactory)
    • MLSRecommendationFeature : Presentation + Domain + Data 구현체
    • MLSRecommendationFeatureTesting : Mock 객체 제공용
  • Package.swift 의존성 구성 (MLSCore, MLSDesignSystem, ReactorKit, RxSwift, SnapKit 등)

MLSRecommendationFeatureExample 세팅

  • SceneDelegate에서 DIContainer를 사용하여 RecommendationMainFactory 등록 및 resolve로 주입
  • UINavigationController를 root로 추천 메인 화면 진입

xcodeproj 패키지 의존성 추가

  • MLSRecommendationFeatureExample 타겟에 MLSRecommendationFeature, MLSRecommendationFeatureInterface, MLSCore 패키지 의존성 추가

추천 메인 화면 초기 UI 구성

  • RecommendationMainViewController : ReactorKit View 채택, bind(reactor:) 구조 세팅
  • RecommendationMainView : Header, ProfileView, grayBackgroundView, CollectionView, informationButton 레이아웃 구성
  • RecommendationProfileView : 프로필 이미지 / 닉네임 / 직업 / 레벨 뱃지 / 수정하기 버튼 구성, ImageLoader로 프로필 이미지 비동기 로드
  • CardListCell : CardList 컴포넌트 래핑
  • CollectionView 레이아웃을 CompositionalLayoutBuilder로 구성

스크린샷

image

👀 ETC (추후 개발해야 할 것, 참고자료 등)

  • RecommendationMainReactor Action / State / Mutation 구현 필요
  • 추천 API 연동 및 실제 데이터 바인딩 필요

@dongglehada dongglehada requested a review from pinocchio22 April 30, 2026 04:05
@dongglehada dongglehada self-assigned this Apr 30, 2026
@dongglehada dongglehada added the feat 새로운 기능을 추가 label Apr 30, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the MLSRecommendationFeature module, encompassing its interface, implementation, and a dedicated example application. The feature includes a main recommendation screen built with ReactorKit and custom UI components like CardListCell and RecommendationProfileView. Feedback identifies several critical issues, including an invalid iOS deployment target (26.1), a missing identifier property in CardListCell that will cause compilation errors, and an unsupported swift-tools-version. Additionally, improvements are suggested to remove debugging placeholder colors, handle system images safely without force unwrapping, and adopt UIButton.Configuration for more robust button layouts.

Comment thread MLS/MLS.xcodeproj/project.pbxproj
@@ -0,0 +1,80 @@
// swift-tools-version: 6.2
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

swift-tools-version6.2로 설정되어 있습니다. 현재 공식 릴리즈된 최신 버전은 6.0 계열이므로, 의도된 것이 아니라면 6.0으로 수정하는 것이 권장됩니다.

Suggested change
// swift-tools-version: 6.2
// swift-tools-version: 6.0

Copy link
Copy Markdown
Contributor

@pinocchio22 pinocchio22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!! 사용하지않는 스토리 보드 파일만 제거하면 좋을 것 같습니다 :)

@dongglehada dongglehada merged commit c009f14 into dev May 6, 2026
2 checks passed
@dongglehada dongglehada deleted the feat/#327-RecommendationFeature-main branch May 6, 2026 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat 새로운 기능을 추가

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants