Merged
Conversation
set-read 제외한 알람관련 API 도메인 주소를 v1->v2로 수정
페이징 시 기존 데이터에 덮어쓰기가 아닌 추가 되고있던 이슈 해결 + 진행중 이벤트 클릭 이슈는 현재 확인 불가능
+ 버전 3.0.0 및 앱 이름 변경
There was a problem hiding this comment.
Code Review
This pull request updates the alarm and notification system by transitioning from API v1 to v2, changing the pagination cursor from a date string to an integer ID, and adding an ID field to alarm response entities. Project configurations were updated to version 3.0.3, and the demo app's dependency injection was modified, though some registrations were commented out. Feedback includes a warning about potential runtime errors in the demo app due to missing dependency resolutions and a performance concern regarding the UI update logic in the announcement and patch note views.
dongglehada
approved these changes
Apr 22, 2026
Member
dongglehada
left a comment
There was a problem hiding this comment.
수고 많으셨습니다!
특이사항은 없어보여서 승인처리 하겠습니다 :>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 이슈
✅ 작업 사항
1. 공지사항 API 변경 대응
2. 설정 화면 공지사항 / 패치노트 페이징 UI 이슈 수정
3. 종료된 이벤트 링크 이동 이슈
👀 ETC (추후 개발해야 할 것, 참고자료 등)