Skip to content

Fix auth and package label copy#111

Merged
Taleef7 merged 1 commit intomainfrom
codex/playwright-audit-fixes
Apr 8, 2026
Merged

Fix auth and package label copy#111
Taleef7 merged 1 commit intomainfrom
codex/playwright-audit-fixes

Conversation

@Taleef7
Copy link
Copy Markdown
Owner

@Taleef7 Taleef7 commented Apr 8, 2026

Summary

  • Fix sign-in copy typo from Don;'t to Don't.
  • Add whitespace to package session labels so accessible text is not concatenated.
  • Add Playwright regression coverage for the copy and package label issues.

Test Plan

  • npm run typecheck
  • npm run lint
  • npm test
  • npm run build:local
  • npm run test:e2e:local
  • npm audit --audit-level=high
  • Manual Playwright pass through lead, signup, student request, payment proof upload, admin payment approval, tutor assignment/session generation, tutor session view, and mobile tutor sessions.

Copilot AI review requested due to automatic review settings April 8, 2026 02:21
@Taleef7 Taleef7 merged commit 2951e9c into main Apr 8, 2026
3 checks passed
@Taleef7 Taleef7 deleted the codex/playwright-audit-fixes branch April 8, 2026 02:23
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a sign-in copy typo and ensures package labels include readable whitespace so screen reader / accessible text doesn’t concatenate values, with Playwright regression tests to prevent recurrence.

Changes:

  • Correct sign-in copy from Don;'t to Don't.
  • Add explicit whitespace between package session counts and the sessions/month label on landing + request form UI.
  • Add Playwright assertions covering both the corrected copy and the non-concatenated package label text.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
e2e/landing.spec.ts Adds regression assertions ensuring package text isn’t rendered as 8sessions/month (no whitespace).
e2e/auth.spec.ts Adds regression coverage for the corrected “Don’t have an account?” sign-in copy.
app/page.tsx Inserts an explicit JSX space between {sessions} and the sessions/month span on the landing packages section.
app/dashboard/requests/new/RequestForm.tsx Ensures a space exists between the package tier value and sessions/month label in the package selector.
app/auth/sign-in/SignInForm.tsx Fixes the Don;'t typo to Don't.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

</span>
)}
<span className="text-2xl font-black text-[#121212]">{value}</span>
<span className="text-2xl font-black text-[#121212]">{value} </span>
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whitespace fix here relies on a trailing literal space inside the JSX ("{value} "). This is easy to miss in reviews and can be unintentionally removed by formatting edits. For consistency with the rest of the repo (and with app/page.tsx in this PR), consider inserting an explicit JSX space node between the two spans instead (e.g., {value} then {' '} then the "sessions/month" span).

Suggested change
<span className="text-2xl font-black text-[#121212]">{value} </span>
<span className="text-2xl font-black text-[#121212]">{value}</span>
{' '}

Copilot uses AI. Check for mistakes.
Comment thread e2e/landing.spec.ts
Comment on lines +19 to +21
await expect(page.getByText(/8sessions\/month/i)).toHaveCount(0);
await expect(page.getByText(/12sessions\/month/i)).toHaveCount(0);
await expect(page.getByText(/20sessions\/month/i)).toHaveCount(0);
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These three negative assertions are nearly identical and could be made more maintainable by iterating over the package counts (8/12/20) in a small loop. That reduces repetition and makes it easier to update if tiers change.

Suggested change
await expect(page.getByText(/8sessions\/month/i)).toHaveCount(0);
await expect(page.getByText(/12sessions\/month/i)).toHaveCount(0);
await expect(page.getByText(/20sessions\/month/i)).toHaveCount(0);
for (const packageCount of [8, 12, 20]) {
await expect(
page.getByText(new RegExp(`${packageCount}sessions\\/month`, "i")),
).toHaveCount(0);
}

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants