Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a sign-in copy typo and ensures package labels include readable whitespace so screen reader / accessible text doesn’t concatenate values, with Playwright regression tests to prevent recurrence.
Changes:
- Correct sign-in copy from
Don;'ttoDon't. - Add explicit whitespace between package session counts and the
sessions/monthlabel on landing + request form UI. - Add Playwright assertions covering both the corrected copy and the non-concatenated package label text.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| e2e/landing.spec.ts | Adds regression assertions ensuring package text isn’t rendered as 8sessions/month (no whitespace). |
| e2e/auth.spec.ts | Adds regression coverage for the corrected “Don’t have an account?” sign-in copy. |
| app/page.tsx | Inserts an explicit JSX space between {sessions} and the sessions/month span on the landing packages section. |
| app/dashboard/requests/new/RequestForm.tsx | Ensures a space exists between the package tier value and sessions/month label in the package selector. |
| app/auth/sign-in/SignInForm.tsx | Fixes the Don;'t typo to Don't. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| </span> | ||
| )} | ||
| <span className="text-2xl font-black text-[#121212]">{value}</span> | ||
| <span className="text-2xl font-black text-[#121212]">{value} </span> |
There was a problem hiding this comment.
The whitespace fix here relies on a trailing literal space inside the JSX ("{value} "). This is easy to miss in reviews and can be unintentionally removed by formatting edits. For consistency with the rest of the repo (and with app/page.tsx in this PR), consider inserting an explicit JSX space node between the two spans instead (e.g., {value} then {' '} then the "sessions/month" span).
| <span className="text-2xl font-black text-[#121212]">{value} </span> | |
| <span className="text-2xl font-black text-[#121212]">{value}</span> | |
| {' '} |
| await expect(page.getByText(/8sessions\/month/i)).toHaveCount(0); | ||
| await expect(page.getByText(/12sessions\/month/i)).toHaveCount(0); | ||
| await expect(page.getByText(/20sessions\/month/i)).toHaveCount(0); |
There was a problem hiding this comment.
These three negative assertions are nearly identical and could be made more maintainable by iterating over the package counts (8/12/20) in a small loop. That reduces repetition and makes it easier to update if tiers change.
| await expect(page.getByText(/8sessions\/month/i)).toHaveCount(0); | |
| await expect(page.getByText(/12sessions\/month/i)).toHaveCount(0); | |
| await expect(page.getByText(/20sessions\/month/i)).toHaveCount(0); | |
| for (const packageCount of [8, 12, 20]) { | |
| await expect( | |
| page.getByText(new RegExp(`${packageCount}sessions\\/month`, "i")), | |
| ).toHaveCount(0); | |
| } |
Summary
Test Plan