Tac/v0.53.6#3
Closed
AkKoks wants to merge 4 commits into
Closed
Conversation
Squashed changes vs upstream v0.53.6:
* LSM (Liquid Staking Module) integration in x/staking
- new messages: TokenizeShares, RedeemTokensForShares,
TransferTokenizeShareRecord, ValidatorBond,
EnableTokenizeShares, DisableTokenizeShares
- liquid_stake.go, tokenize_share_record.go, params,
keys, errors, events, hooks, expected_keepers
- regenerated proto (genesis, query, tx, staking)
- originally backported by PixelPlex on v0.50, adapted to
v0.53.6 API: math.Int / math.LegacyDec, context.Context,
KVStoreService, AddressCodec
* Mocks regenerated with go.uber.org/mock v0.6.0
* Makefile: bump mockgen to v0.6.0 (Go 1.25 compatibility)
* types/coin_test.go: TestQuoIntCoins uses semantic Coins.Equal
instead of reflect.DeepEqual (Go 1.25 big.Int internal change)
* Lint, gci/gofumpt, test fixes (gas usage in staking queries,
api test diff, changelog)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
gosec found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Squash LSM audit fixes and regressions after the v0.53.6 TAC fork. - restore LSM staking state during InitGenesis and add genesis validation/regression coverage - clean expired tokenize-share locks in BeginBlocker and fix unlock queue handling - return explicit errors for invalid tokenized-share reward withdrawals and tolerate missing final module delegation during reward cleanup - validate LSM staking params - preserve proto, Amino, interface, REST and generated metadata for LSM messages and queries while keeping CLI/AutoCLI tokenized-share support unsupported by design - harden global and validator liquid-staking cap checks, amount/dust handling, and total-liquid-staked refresh error propagation - remove the unused local module-address helper and keep the original 32-byte liquid-staker heuristic - fix tokenized-share REST denom lookup for slash denoms - maintain liquid shares and validator-bond shares across delegate, redelegate, undelegate, cancel-unbonding, validator slash, and redelegation slash paths - preserve upstream BeginRedelegate missing-destination error semantics after adding LSM accounting - add focused regression tests for fixed LSM paths
Add an in-memory staking keeper allowlist for MsgTokenizeShares delegators. By default the allowlist is empty and preserves unrestricted SDK behavior; TAC can wire LiquidStakeProxyAcc as the only allowed delegator at app construction time.\n\nReject unauthorized tokenization attempts in the msg server and cover unrestricted, denied, and allowed paths with a regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major upgrade to Cosmos SDK v0.53.6
This PR hard-rebases our TAC Cosmos SDK fork onto upstream
cosmos-sdkv0.53.6 and re-applies the TAC-specific LSM changes on top of the new SDK base.Summary:
cosmos-sdkv0.53.6iqlusioninc/liquidity-staking-modulewhere applicableBeginBlockerx/distribution