You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR fixes#27 by adding support for multiple modules, including shared memory, tables, globals and cross-module function calls.
Currently no official Wasm nor unofficial tests have been included in the Latch spectest suite. To test the multiple module functionality, see the test examples in /tutorials/wat/main/mtuliple_modules_mX.wast. These example tests include the demonstration of:
Should we include Latch spectests to cover this multi-module extension?
In that case, I presume Latch must be upgraded first for it to be capable of handling the compilation and linking of multiple modules?
@tolauwae I see you compiled every multiple_module_mX.wast to modX.wasm. This, however, only works when you also update the import modules in those .wast files, as they expect the names of the (imported) modules to be in the multiple_module_mX format. Otherwise, they can't find the modules to import, resulting in this seemingly unrelated error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #27 by adding support for multiple modules, including shared memory, tables, globals and cross-module function calls.
Currently no official Wasm nor unofficial tests have been included in the Latch spectest suite. To test the multiple module functionality, see the test examples in
/tutorials/wat/main/mtuliple_modules_mX.wast. These example tests include the demonstration of:You can provide multiple modules to the CLI by linking modules using the --link flag (e.g.
./wdcli mod1.wasm --link mod2.wasm mod3.wasm).