kegg: fetch the HMM library from the raven-data kegg118 release#643
Merged
Conversation
Function test results202 tests 178 ✅ 39s ⏱️ Results for commit 004da21. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getKEGGModelForOrganismdownloads the prebuilt KO HMM libraries on demand.develop3already targets KEGG 118 but points at araven-toolboxrelease (v0.3.0). This repoints the download to the dedicatedraven-datarepository, where the shared artefacts are now hosted as release assets.Change
reconstruction/kegg/getKEGGModelForOrganism.m: thewebsaveURL →https://github.com/SysBioChalmers/raven-data/releases/download/kegg118/<hmmName>.hmm.gz(e.g.
kegg118_eukaryotes.hmm.gz), plus the doc comment now names raven-data.Why raven-data
The HMM libraries (~135–155 MB each) exceed GitHub's 100 MB git-file limit, so they can only live as release assets. Hosting them in a dedicated data repo (rather than attached to a code release) keeps code releases clean, isolates the assets' licenses, and gives MATLAB RAVEN and Python raven-toolbox one shared, SHA256-indexed source of truth (
manifest.json). See the raven-data README and raven-toolbox'sdocs/maintenance/artefact_hosting.md.Verified
The
kegg118release exists in raven-data with all four assets; the new URL resolves (302 → asset,HTTP 200). Companion raven-toolbox PR: SysBioChalmers/raven-toolbox#43.